* PATCH: free mm if spufs_fill_dir() failed
@ 2007-05-04 17:27 Sebastian Siewior
2007-05-09 6:08 ` Jeremy Kerr
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Siewior @ 2007-05-04 17:27 UTC (permalink / raw)
To: linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 2 bytes --]
[-- Attachment #2: spufs-free_mm.diff --]
[-- Type: text/plain, Size: 592 bytes --]
In case spufs_fill_dir() fails only put_spu_context()
gets called for cleanup and the acquired mm_struct never gets freed.
Signed-off-by: Sebastian Siewior <bigeasy@linux.vnet.ibm.com>
Index: ps3-linux/arch/powerpc/platforms/cell/spufs/inode.c
===================================================================
--- ps3-linux.orig/arch/powerpc/platforms/cell/spufs/inode.c
+++ ps3-linux/arch/powerpc/platforms/cell/spufs/inode.c
@@ -277,6 +277,7 @@ spufs_mkdir(struct inode *dir, struct de
goto out;
out_free_ctx:
+ spu_forget(ctx);
put_spu_context(ctx);
out_iput:
iput(inode);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PATCH: free mm if spufs_fill_dir() failed
2007-05-04 17:27 PATCH: free mm if spufs_fill_dir() failed Sebastian Siewior
@ 2007-05-09 6:08 ` Jeremy Kerr
0 siblings, 0 replies; 2+ messages in thread
From: Jeremy Kerr @ 2007-05-09 6:08 UTC (permalink / raw)
To: linuxppc-dev
Sebastian,
> In case spufs_fill_dir() fails only put_spu_context()
> gets called for cleanup and the acquired mm_struct never gets freed.
Good catch. However - could we do the mmput in the context destroy path
instead?
Also, you're probably better-off sending patches inline. It makes
commenting on the patch much easier for some mailers.
Cheers,
Jeremy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-09 6:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-04 17:27 PATCH: free mm if spufs_fill_dir() failed Sebastian Siewior
2007-05-09 6:08 ` Jeremy Kerr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).