From: linas@austin.ibm.com (Linas Vepstas)
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 3/4] powerpc: EEH: capture and log pci state on error
Date: Wed, 9 May 2007 11:29:45 -0500 [thread overview]
Message-ID: <20070509162945.GU4452@austin.ibm.com> (raw)
In-Reply-To: <20070509045439.GB1771@lixom.net>
On Tue, May 08, 2007 at 11:54:39PM -0500, Olof Johansson wrote:
> Hi,
>
> > +#define EEH_PCI_REGS_LOG_LEN 4096
> > +static unsigned char pci_regs_buf[EEH_PCI_REGS_LOG_LEN];
>
> I'm guessing this has to be in BSS because of the requrements of being
> addressable in realmode for RTAS? Could be nice to document in a comment
> so noone tries to make it a local variable later on.
Yep, exactly. Funny, I thought exactly that: "Someone is going to want
me to change this to a kmalloc. What should I do to avoid this
question?" It never occured to me that all I needed was a mere comment.
--linas
next prev parent reply other threads:[~2007-05-09 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 23:09 [PATCH 0/4] powerpc: EEH: extend PCI error logging to dump register state Linas Vepstas
2007-05-08 23:33 ` [PATCH 1/4] powerpc: EEH: log error only after driver notification Linas Vepstas
2007-05-09 4:51 ` Olof Johansson
2007-05-09 16:11 ` Linas Vepstas
2007-05-08 23:34 ` [PATCH 2/4] powerpc: EEH: Split up long error msg Linas Vepstas
2007-05-08 23:35 ` [PATCH 3/4] powerpc: EEH: capture and log pci state on error Linas Vepstas
2007-05-09 4:54 ` Olof Johansson
2007-05-09 16:29 ` Linas Vepstas [this message]
2007-05-08 23:36 ` [PATCH 4/4] powerpc: EEH: log all PCI-X and PCI-E AER registers Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509162945.GU4452@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).