linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: linas@austin.ibm.com (Linas Vepstas)
To: Paul Mackerras <paulus@samba.org>
Cc: Olof Johansson <olof@lixom.net>, linuxppc-dev <Linuxppc-dev@ozlabs.org>
Subject: Re: arch/powerpc/sysdev: dumping ground or only for shared drivers?
Date: Fri, 11 May 2007 12:05:13 -0500	[thread overview]
Message-ID: <20070511170512.GH4452@austin.ibm.com> (raw)
In-Reply-To: <17987.47155.935764.878634@cargo.ozlabs.ibm.com>

On Fri, May 11, 2007 at 10:26:27AM +1000, Paul Mackerras wrote:
> Olof Johansson writes:
> 
> > This adds yet another set of chipset drivers under sysdev, that are
> > only used by one platform (several board ports under that platform,
> > but only one platforms/* directory).
> > 
> > In my opinion, they really should go under the platform directory instead,
> > and not clutter the shared directory.
> 
> I disagree, actually.  Having these things in a shared directory makes
> it more likely that people will look at the code.  That means that
> it's more likely that bugs will be found, and more likely that parts
> of the code can get reused when people are doing the port to a new
> chip or board.
> 
> If there were hundreds of files in arch/powerpc/sysdev then I would be
> more likely to agree with you, but there aren't.

I like Paul's take, it matches my gut instincts.

--linas

  reply	other threads:[~2007-05-11 17:05 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-10 20:02 [PATCH 0/13] powerpc: Add support for Marvell/mv64x60 and prpmc2800 Mark A. Greer
2007-05-10 20:04 ` [PATCH 1/13] powerpc: Add Makefile rules to wrap dts file in zImage Mark A. Greer
2007-05-10 23:29   ` David Gibson
2007-05-11 15:59     ` Mark A. Greer
2007-05-10 20:05 ` [PATCH 2/13] powerpc: Add bootwrapper support for Marvell/mv64x60 hostbridge Mark A. Greer
2007-05-10 20:05 ` [PATCH 3/13] powerpc: Add bootwrapper support for Marvell MPSC Mark A. Greer
2007-05-10 20:06 ` [PATCH 4/13] powerpc: Add bootwrapper support for Marvell/mv64x60 I2C Mark A. Greer
2007-05-10 20:06 ` [PATCH 5/13] powerpc: Add interrupt support for Marvell mv64x60 chips Mark A. Greer
2007-05-10 20:07 ` [PATCH 6/13] powerpc: Create Marvell mv64x60 MPSC (serial) platform_data Mark A. Greer
2007-05-10 20:07 ` [PATCH 7/13] powerpc: Create Marvell mv64x60 ethernet platform_data Mark A. Greer
2007-05-10 20:07 ` [PATCH 8/13] powerpc: Create Marvell mv64x60 I2C platform_data Mark A. Greer
2007-05-10 20:08 ` [PATCH 9/13] powerpc: Add Marvell mv64x60 PCI bridge support Mark A. Greer
2007-05-10 20:08 ` [PATCH 10/13] powerpc: check cache coherency of kernel vs firmware Mark A. Greer
2007-05-10 20:08 ` [PATCH 11/13] powerpc: Add DTS file for the Motorola PrPMC2800 platform Mark A. Greer
2007-05-10 21:44   ` Kumar Gala
2007-05-10 23:37   ` David Gibson
2007-05-12 11:59     ` Segher Boessenkool
2007-05-13  0:00       ` Jerry Van Baren
2007-05-13  0:21         ` Segher Boessenkool
2007-05-13 12:50           ` Jerry Van Baren
2007-05-13 14:45             ` Segher Boessenkool
2007-05-13  1:10       ` David Gibson
2007-05-10 20:09 ` [PATCH 12/13] powerpc: Add bootwrapper support for " Mark A. Greer
2007-05-10 20:09 ` [PATCH 13/13] powerpc: Add arch/powerpc support for the Motorola PrPMC2800 Mark A. Greer
2007-05-10 21:57 ` arch/powerpc/sysdev: dumping ground or only for shared drivers? Olof Johansson
2007-05-10 22:06   ` Kumar Gala
2007-05-11  1:00     ` Josh Boyer
2007-05-15  9:53     ` Christian Krafft
2007-05-10 22:40   ` David Gibson
2007-05-10 23:00   ` Mark A. Greer
2007-05-11  0:26   ` Paul Mackerras
2007-05-11 17:05     ` Linas Vepstas [this message]
2007-05-15 21:06       ` Kumar Gala
2007-05-15 22:06         ` Mark A. Greer
2007-05-15 22:19           ` Grant Likely
2007-05-15 22:25             ` Olof Johansson
2007-05-15 22:30               ` Kumar Gala
2007-05-15 23:56               ` Mark A. Greer
2007-05-16  0:32           ` Mark A. Greer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070511170512.GH4452@austin.ibm.com \
    --to=linas@austin.ibm.com \
    --cc=Linuxppc-dev@ozlabs.org \
    --cc=olof@lixom.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).