From: olof@lixom.net (Olof Johansson)
To: paulus@samba.org
Cc: linuxppc-dev@ozlabs.org, linux-pcmcia@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] pcmcia: ppc64 needs 64-bit ioaddr_t
Date: Sat, 12 May 2007 09:31:05 -0500 [thread overview]
Message-ID: <20070512143105.GA12890@lixom.net> (raw)
ppc64 really needs ioaddr_t to be 64-bit, since I/O addresses really
are MMIO addresses, and remapped to a high range.
While the type is exported to userspace, there hasn't been any platforms
with PCMCIA on 64-bit powerpc until now, so changing it won't regress
any existing users.
Signed-off-by: Olof Johansson <olof@lixom.net>
Index: 2.6.21/include/pcmcia/cs_types.h
===================================================================
--- 2.6.21.orig/include/pcmcia/cs_types.h
+++ 2.6.21/include/pcmcia/cs_types.h
@@ -21,12 +21,17 @@
#include <sys/types.h>
#endif
+#if defined(__powerpc64__)
+/* I/O addresses are really MMIO addresses on PPC, and can thus be 64 bits */
+typedef unsigned long ioaddr_t;
+#else
#if defined(__arm__) || defined(__mips__)
/* This (ioaddr_t) is exposed to userspace & hence cannot be changed. */
typedef u_int ioaddr_t;
#else
typedef u_short ioaddr_t;
#endif
+#endif
typedef unsigned long kio_addr_t;
typedef u_short socket_t;
next reply other threads:[~2007-05-12 14:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-12 14:31 Olof Johansson [this message]
2007-05-13 21:22 ` [PATCH] pcmcia: ppc64 needs 64-bit ioaddr_t Olof Johansson
2007-05-13 21:46 ` Christoph Hellwig
2007-05-14 22:57 ` Olof Johansson
2007-05-15 5:52 ` Christoph Hellwig
2007-05-14 22:08 ` Andrew Morton
2007-05-14 22:47 ` Benjamin Herrenschmidt
2007-05-14 22:59 ` Olof Johansson
2007-05-15 4:33 ` [PATCH v2] pcmcia: ppc64 needs 32-bit ioaddr_t Olof Johansson
2007-05-15 7:35 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070512143105.GA12890@lixom.net \
--to=olof@lixom.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).