From: David Gibson <david@gibson.dropbear.id.au>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [DTC PATCH] Remove overreaching semantic tests.
Date: Mon, 14 May 2007 11:19:15 +1000 [thread overview]
Message-ID: <20070514011915.GH6517@localhost.localdomain> (raw)
In-Reply-To: <20070511175553.GA14692@ld0162-tx32.am.freescale.net>
On Fri, May 11, 2007 at 12:55:54PM -0500, Scott Wood wrote:
> Now that there are more usage models than "complete device tree in the
> DTS" and "minimally device-tree aware u-boot that still needs zeroed out
> properties to fill in", many of the checks that dtc performs are no
> longer appropriate, since the nodes and properties in question can be
> added at runtime.
>
> Note that -f is *not* an alternative, as that suppresses all checks. I
> still want it to check for things that are present but wrong; I just
> don't want it complaining about things that aren't there at all.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> I wouldn't be opposed to keeping these tests around if there were a
> command line option that cleanly separates the errors/warnings into
> classes such as structural, semantic-missing, semantic-broken, etc.
Exactly - which is why I really don't want to simply tear out this
checking code. I've never gotten around to reworking the
error/warning system so it can sensibly divide things into such
classes, and keep detecting further warnings after picking up some
non-fatal ones and so forth.
I'd much prefer you just disable these tests for now, either by
commenting code out, or removing calls to checking functions. That
will make it easier to optionally reinstate later.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-05-14 1:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 17:55 [DTC PATCH] Remove overreaching semantic tests Scott Wood
2007-05-14 1:19 ` David Gibson [this message]
2007-05-14 12:40 ` Segher Boessenkool
2007-05-14 15:51 ` Scott Wood
2007-05-15 0:57 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070514011915.GH6517@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).