From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from az33egw02.freescale.net (az33egw02.freescale.net [192.88.158.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "az33egw02.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id EEEABDDE25 for ; Tue, 15 May 2007 02:28:35 +1000 (EST) Date: Mon, 14 May 2007 11:28:16 -0500 From: Scott Wood To: Paul Mackerras , "Mark A. Greer" , linuxppc-dev@ozlabs.org Subject: Re: Fix bug adding properties with flatdevtree.c's ft_set_prop() Message-ID: <20070514162816.GB371@ld0162-tx32.am.freescale.net> References: <20070514031357.GM6517@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070514031357.GM6517@localhost.localdomain> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, May 14, 2007 at 01:13:57PM +1000, David Gibson wrote: > This patch corrects ft_set_prop() so that it adds new properties > before the first subnode, instead of before the END_NODE tag. Is there any reason not to just insert at the beginning of the node? -Scott