From: David Gibson <david@gibson.dropbear.id.au>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: Fix bug adding properties with flatdevtree.c's ft_set_prop()
Date: Tue, 15 May 2007 10:26:48 +1000 [thread overview]
Message-ID: <20070515002648.GA31585@localhost.localdomain> (raw)
In-Reply-To: <20070514162816.GB371@ld0162-tx32.am.freescale.net>
On Mon, May 14, 2007 at 11:28:16AM -0500, Scott Wood wrote:
> On Mon, May 14, 2007 at 01:13:57PM +1000, David Gibson wrote:
> > This patch corrects ft_set_prop() so that it adds new properties
> > before the first subnode, instead of before the END_NODE tag.
>
> Is there any reason not to just insert at the beginning of the node?
Only that we have to search through the node first to see if the
property already exists, so we've already reached the end by the time
we know we need to insert.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-05-15 0:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-14 3:13 Fix bug adding properties with flatdevtree.c's ft_set_prop() David Gibson
2007-05-14 16:28 ` Scott Wood
2007-05-15 0:26 ` David Gibson [this message]
2007-05-15 18:11 ` Mark A. Greer
2007-05-15 23:05 ` David Gibson
2007-05-15 17:49 ` Scott Wood
2007-05-15 18:08 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070515002648.GA31585@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).