Re: [PATCH 3/3] Bamboo wrapper

[David Gibson <dwg@au1.ibm.com>]

On Mon, May 14, 2007 at 09:59:51AM -0500, Josh Boyer wrote:
> Add a bootwrapper for Bamboo

[snip]
> +#define DCRN_MAL0_CFG 0x180
> +static void ibm440ep_reset_eth(void)
> +{
> +	/* reset the MAL and EMACs since PIBS doesn't do this for us */
> +	u32 *emac0 = (u32 *)0xef600e00;
> +	u32 *emac1 = (u32 *)0xef600f00;
> +
> +	*emac0 = 0x20000000;
> +	*emac1 = 0x20000000;
> +	mtdcr(DCRN_MAL0_CFG, 0x80000000);
> +}

Since a number of 4xx board firmware suffer from this EMAC/MAL reset
problem it would be nice to factor this out into a common file.

> +static void ibm440ep_clear_uics(void)
> +{
> +	/* Clear the UIC registers so we don't get spurious interrupts
> +	 * in the kernel
> +	 */
> +	mtdcr(DCRN_UIC0_ER, 0x0);
> +	mtdcr(DCRN_UIC0_SR, 0xffffffff);
> +	mtdcr(DCRN_UIC1_ER, 0x0);
> +	mtdcr(DCRN_UIC1_SR, 0xffffffff);
> +}

I don't think we should need this.  As you suggested I added such a
clear to my UIC driver in the kernel proper.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson