From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: [PATCH] powerpc: Fix warning in pci_64.c
Date: Tue, 15 May 2007 14:16:35 +1000 [thread overview]
Message-ID: <20070515041705.CCC00DDFC9@ozlabs.org> (raw)
Fix a warning due to unused result from device_create_file
in arch/powerpc/kernel/pci_64.c
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/kernel/pci_64.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-cell/arch/powerpc/kernel/pci_64.c
===================================================================
--- linux-cell.orig/arch/powerpc/kernel/pci_64.c 2007-05-15 14:14:15.000000000 +1000
+++ linux-cell/arch/powerpc/kernel/pci_64.c 2007-05-15 14:14:54.000000000 +1000
@@ -878,7 +878,8 @@ static DEVICE_ATTR(devspec, S_IRUGO, pci
void pcibios_add_platform_entries(struct pci_dev *pdev)
{
- device_create_file(&pdev->dev, &dev_attr_devspec);
+ int rc = device_create_file(&pdev->dev, &dev_attr_devspec);
+ WARN_ON(rc != 0);
}
#define ISA_SPACE_MASK 0x1
next reply other threads:[~2007-05-15 4:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 4:16 Benjamin Herrenschmidt [this message]
2007-05-15 4:30 ` [PATCH] powerpc: Fix warning in pci_64.c Stephen Rothwell
2007-05-15 6:03 ` Michael Ellerman
2007-05-15 6:03 ` Benjamin Herrenschmidt
2007-05-15 8:22 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070515041705.CCC00DDFC9@ozlabs.org \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).