From: David Gibson <david@gibson.dropbear.id.au>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: Small fixes for the Ebony device tree
Date: Tue, 15 May 2007 15:47:58 +1000 [thread overview]
Message-ID: <20070515054758.GC6998@localhost.localdomain> (raw)
In-Reply-To: <8492e53122b6e1ba269afd53b48a4968@kernel.crashing.org>
On Tue, May 15, 2007 at 07:11:07AM +0200, Segher Boessenkool wrote:
> Just a few more things...
>
> > plb {
> > - device_type = "ibm,plb";
> > compatible = "ibm,plb-440gp", "ibm,plb4";
>
> You match on "ibm,plb" though. Well you got one
> in three right ;-)
Indeed. And I'm still not sure how it's recognizing the plb devices
right now...
> > + SDRAM0: memory-controller {
> > compatible = "ibm,sdram-440gp", "ibm,sdram";
>
> "ibm,sdram" is way too generic to ever be usefully
> used for device matching.
Yeah, I guess this should be ibm,sdram-44x or ibm,sdram-4xx. Better
go look up if any 40x chips use a similar sdram controller.
> > + SRAM0: sram {
> > + compatible = "ibm,sram440gp";
>
> You spell this one without a dash, all others with one.
Ah, yes, oops...
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-05-15 5:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 2:00 Small fixes for the Ebony device tree David Gibson
2007-05-15 5:11 ` Segher Boessenkool
2007-05-15 5:47 ` David Gibson [this message]
2007-05-15 6:11 ` Stefan Roese
2007-05-15 6:18 ` David Gibson
2007-05-15 6:28 ` Segher Boessenkool
2007-05-15 6:34 ` David Gibson
2007-05-15 6:47 ` Segher Boessenkool
2007-05-15 6:58 ` David Gibson
2007-05-15 7:07 ` Segher Boessenkool
2007-05-16 3:47 ` David Gibson
2007-05-15 6:46 ` Stefan Roese
2007-05-15 7:02 ` Segher Boessenkool
-- strict thread matches above, loose matches on Subject: below --
2007-05-16 3:48 David Gibson
2007-05-16 13:35 ` Segher Boessenkool
2007-05-14 4:54 David Gibson
2007-05-14 12:22 ` Josh Boyer
2007-05-14 12:59 ` Segher Boessenkool
2007-05-14 15:09 ` Josh Boyer
2007-05-15 1:17 ` David Gibson
2007-05-15 4:59 ` Segher Boessenkool
2007-05-15 5:46 ` David Gibson
2007-05-16 3:47 ` David Gibson
2007-05-15 18:15 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070515054758.GC6998@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).