From: David Brownell <david-b@pacbell.net>
To: "Grant Likely" <grant.likely@secretlab.ca>
Cc: rtc-linux@googlegroups.com, James Chapman <jchapman@katalix.com>,
linuxppc-dev@ozlabs.org, i2c@lm-sensors.org,
Jean Delvare <khali@linux-fr.org>
Subject: Re: [i2c] [PATCH] Make i2c-mpc driver use i2c_add_numbered_adapter
Date: Tue, 15 May 2007 09:05:20 -0700 [thread overview]
Message-ID: <200705150905.21559.david-b@pacbell.net> (raw)
In-Reply-To: <528646bc0705150851pa578a56nc0dc171677748e5a@mail.gmail.com>
On Tuesday 15 May 2007, Grant Likely wrote:
>
> Take another look; this is a funny quirk of the driver. The
> assignment is 'i2c->adap = mpc_ops'; not 'i2c->adap = &mpc_ops'. And
> in struct mpc_i2c, the field is declared as 'struct i2c_adapter adap',
> not 'struct i2c_adapter *adap'. The driver instance gets a copy of
> the mpc_ops structure to initialize it, not a pointer to the staticly
> defined structure. I got bitten by the same thing when I was looking
> at the code.
I see -- you're right. That "template" idiom is a good one to get
rid of, FWIW ... not only is it confusing, but it also wastes space.
- Dave
next prev parent reply other threads:[~2007-05-15 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-14 19:11 [PATCH] Make i2c-mpc driver use i2c_add_numbered_adapter Grant Likely
2007-05-14 19:32 ` Grant Likely
2007-05-15 13:26 ` [i2c] " Jean Delvare
2007-05-15 15:28 ` David Brownell
2007-05-15 15:51 ` Grant Likely
2007-05-15 16:05 ` David Brownell [this message]
2007-05-16 18:25 ` Jean Delvare
2007-05-16 18:38 ` Grant Likely
2007-05-16 19:15 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705150905.21559.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=grant.likely@secretlab.ca \
--cc=i2c@lm-sensors.org \
--cc=jchapman@katalix.com \
--cc=khali@linux-fr.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).