From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 16 May 2007 09:05:41 +1000 From: David Gibson To: "Mark A. Greer" Subject: Re: Fix bug adding properties with flatdevtree.c's ft_set_prop() Message-ID: <20070515230541.GA20290@localhost.localdomain> References: <20070514031357.GM6517@localhost.localdomain> <20070514162816.GB371@ld0162-tx32.am.freescale.net> <20070515002648.GA31585@localhost.localdomain> <20070515181140.GD17643@mag.az.mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070515181140.GD17643@mag.az.mvista.com> Cc: linuxppc-dev@ozlabs.org, Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, May 15, 2007 at 11:11:40AM -0700, Mark A. Greer wrote: > On Tue, May 15, 2007 at 10:26:48AM +1000, David Gibson wrote: > > On Mon, May 14, 2007 at 11:28:16AM -0500, Scott Wood wrote: > > > On Mon, May 14, 2007 at 01:13:57PM +1000, David Gibson wrote: > > > > This patch corrects ft_set_prop() so that it adds new properties > > > > before the first subnode, instead of before the END_NODE tag. > > > > > > Is there any reason not to just insert at the beginning of the node? > > > > Only that we have to search through the node first to see if the > > property already exists, so we've already reached the end by the time > > we know we need to insert. > > David, Jon, > > Does dtc guarantee that there aren't any properties after a subnode? Yes. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson