* [PATCH] powerpc: Fix VDSO compile warning [not found] <7f6b534db16116013b0f802a2dc8bd87c7e16508.1179328270.git.segher@kernel.crashing.org> @ 2007-05-16 15:12 ` Segher Boessenkool 2007-05-17 1:27 ` Stephen Rothwell 0 siblings, 1 reply; 4+ messages in thread From: Segher Boessenkool @ 2007-05-16 15:12 UTC (permalink / raw) To: linuxppc-dev Maybe the type should have been char[] instead of __u8[] in the first place, but this will do. Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org> --- arch/powerpc/kernel/vdso.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c index 4245579..cef01e4 100644 --- a/arch/powerpc/kernel/vdso.c +++ b/arch/powerpc/kernel/vdso.c @@ -670,7 +670,7 @@ static int __init vdso_init(void) /* * Fill up the "systemcfg" stuff for backward compatiblity */ - strcpy(vdso_data->eye_catcher, "SYSTEMCFG:PPC64"); + strcpy((char *)vdso_data->eye_catcher, "SYSTEMCFG:PPC64"); vdso_data->version.major = SYSTEMCFG_MAJOR; vdso_data->version.minor = SYSTEMCFG_MINOR; vdso_data->processor = mfspr(SPRN_PVR); -- 1.5.2.rc0.g4342-dirty ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: Fix VDSO compile warning 2007-05-16 15:12 ` [PATCH] powerpc: Fix VDSO compile warning Segher Boessenkool @ 2007-05-17 1:27 ` Stephen Rothwell 2007-05-17 1:46 ` Stephen Rothwell 2007-05-17 11:47 ` Segher Boessenkool 0 siblings, 2 replies; 4+ messages in thread From: Stephen Rothwell @ 2007-05-17 1:27 UTC (permalink / raw) To: Segher Boessenkool; +Cc: linuxppc-dev [-- Attachment #1: Type: text/plain, Size: 428 bytes --] On Wed, 16 May 2007 17:12:16 +0200 Segher Boessenkool <segher@kernel.crashing.org> wrote: > > Maybe the type should have been char[] instead of __u8[] > in the first place, but this will do. What warning do you get? What compiler version? I don't get a warning using version 4.1.2 20061115 (prerelease) (Debian 4.1.1-21). -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: Fix VDSO compile warning 2007-05-17 1:27 ` Stephen Rothwell @ 2007-05-17 1:46 ` Stephen Rothwell 2007-05-17 11:47 ` Segher Boessenkool 1 sibling, 0 replies; 4+ messages in thread From: Stephen Rothwell @ 2007-05-17 1:46 UTC (permalink / raw) To: Segher Boessenkool; +Cc: linuxppc-dev [-- Attachment #1: Type: text/plain, Size: 357 bytes --] On Thu, 17 May 2007 11:27:04 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > I don't get a warning using version 4.1.2 20061115 (prerelease) (Debian > 4.1.1-21). Actually, version 4.1.3 20070429 (prerelease) (Debian 4.1.2-5) (Damn distcc :-)) -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: Fix VDSO compile warning 2007-05-17 1:27 ` Stephen Rothwell 2007-05-17 1:46 ` Stephen Rothwell @ 2007-05-17 11:47 ` Segher Boessenkool 1 sibling, 0 replies; 4+ messages in thread From: Segher Boessenkool @ 2007-05-17 11:47 UTC (permalink / raw) To: Stephen Rothwell; +Cc: linuxppc-dev >> Maybe the type should have been char[] instead of __u8[] >> in the first place, but this will do. > > What warning do you get? Oh sorry, should have mentioned that: arch/powerpc/kernel/vdso.c: In function 'vdso_init': arch/powerpc/kernel/vdso.c:673: warning: passing argument 1 of 'strcpy' from incompatible pointer type > What compiler version? GCC mainline of two days ago. Segher ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-05-17 11:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <7f6b534db16116013b0f802a2dc8bd87c7e16508.1179328270.git.segher@kernel.crashing.org>
2007-05-16 15:12 ` [PATCH] powerpc: Fix VDSO compile warning Segher Boessenkool
2007-05-17 1:27 ` Stephen Rothwell
2007-05-17 1:46 ` Stephen Rothwell
2007-05-17 11:47 ` Segher Boessenkool
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).