From: David Gibson <david@gibson.dropbear.id.au>
To: Valentine Barshak <vbarshak@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: New version of the device tree aware EMAC driver
Date: Mon, 21 May 2007 15:06:32 +1000 [thread overview]
Message-ID: <20070521050632.GA7778@localhost.localdomain> (raw)
In-Reply-To: <464B475A.4090808@ru.mvista.com>
On Wed, May 16, 2007 at 10:03:06PM +0400, Valentine Barshak wrote:
> Valentine Barshak wrote:
> > David Gibson wrote:
> >
> >> I've made a few more tiny tweaks to BenH's rewritten device-tree based
> >> 4xx EMAC driver. The main change is that it now no longer requires
> >> 'device_type', just 'compatible' to be set in the ZMII and MAL device
> >> nodes when probing. This works better with current thinking on
> >> flattened device trees which discourages creating new device_type
> >> values unless there is a clear use for a new device class binding.
> >>
> >> The patch can be obtained from:
> >>
> >> http://ozlabs.org/~dgibson/home/emac/powerpc-emac-new-20070516.patch
> >>
> >>
> >>
> > In __emac_mdio_read and __emac_mdio_write functions:
> >
> > + if (!emac_has_feature(dev, EMAC_FTR_STACR_OC_INVERT))
> > + r |= EMAC_STACR_OC;
> >
> > should be
> >
> > + if (emac_has_feature(dev, EMAC_FTR_STACR_OC_INVERT))
> > + r |= EMAC_STACR_OC;
> >
> > Thanks.
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@ozlabs.org
> > https://ozlabs.org/mailman/listinfo/linuxppc-dev
> >
> With the above 2 fixes (and Marvell 88E1111 Ethernet PHY support added)
> seems to work fine on Sequoia PPC440EPx,
> thanks.
Ok, I've merged those fixes. New version of the driver coming soon.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
prev parent reply other threads:[~2007-05-21 5:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 3:26 New version of the device tree aware EMAC driver David Gibson
2007-05-16 16:18 ` Valentine Barshak
2007-05-16 17:00 ` Valentine Barshak
2007-05-16 18:03 ` Valentine Barshak
2007-05-21 5:06 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070521050632.GA7778@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=vbarshak@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).