[PATCH] [POWERPC] Some extra via-pmu exports

[PATCH] [POWERPC] Some extra via-pmu exports

[Stephen Rothwell]

pmu_battery_count, pmu_batteries, pmu_power_flags were only exported
for 32 bit builds but are now needed for 64 bit as well.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/macintosh/via-pmu.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 157080b..07c189c 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -2841,10 +2841,10 @@ EXPORT_SYMBOL(pmu_wait_complete);
 EXPORT_SYMBOL(pmu_suspend);
 EXPORT_SYMBOL(pmu_resume);
 EXPORT_SYMBOL(pmu_unlock);
-#if defined(CONFIG_PM) && defined(CONFIG_PPC32)
-EXPORT_SYMBOL(pmu_enable_irled);
 EXPORT_SYMBOL(pmu_battery_count);
 EXPORT_SYMBOL(pmu_batteries);
 EXPORT_SYMBOL(pmu_power_flags);
+#if defined(CONFIG_PM) && defined(CONFIG_PPC32)
+EXPORT_SYMBOL(pmu_enable_irled);
 #endif /* CONFIG_PM && CONFIG_PPC32 */
 
-- 
1.5.1.4

Re: [PATCH] [POWERPC] Some extra via-pmu exports

[Arnd Bergmann]

On Monday 21 May 2007, Stephen Rothwell wrote:
> pmu_battery_count, pmu_batteries, pmu_power_flags were only exported
> for 32 bit builds but are now needed for 64 bit as well.
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

I haven't seen this one show up in 2.6.22-rc or powerpc.git yet,
but I think we should have it in there to avoid build breakage.

I stumbled over the same bug and wanted to submit a fix when
I saw it was posted already.

	Arnd <><

Re: [PATCH] [POWERPC] Some extra via-pmu exports

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

On Wed, 2007-06-06 at 16:05 +0200, Arnd Bergmann wrote:
> On Monday 21 May 2007, Stephen Rothwell wrote:
> > pmu_battery_count, pmu_batteries, pmu_power_flags were only exported
> > for 32 bit builds but are now needed for 64 bit as well.
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 
> I haven't seen this one show up in 2.6.22-rc or powerpc.git yet,
> but I think we should have it in there to avoid build breakage.
> 
> I stumbled over the same bug and wanted to submit a fix when
> I saw it was posted already.

Actually, I think that with the latest patch I sent that disallows you
to build APM-emulation for 64-bit (which doesn't make sense) this
shouldn't be a problem any more. Are tehre still some that need
exporting?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: [PATCH] [POWERPC] Some extra via-pmu exports

[Arnd Bergmann]

On Wednesday 06 June 2007, Johannes Berg wrote:
> Actually, I think that with the latest patch I sent that disallows you
> to build APM-emulation for 64-bit (which doesn't make sense) this
> shouldn't be a problem any more. Are tehre still some that need
> exporting?

Sorry, I must have missed your patch.
I can confirm that in 2.6.22-rc4 Stephen's patch is no longer needed.

	Arnd <><