From: linas@austin.ibm.com (Linas Vepstas)
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] pseries: asm/pci-bridge.h CONFIG_ minor cleanup
Date: Tue, 22 May 2007 12:00:58 -0500 [thread overview]
Message-ID: <20070522170058.GJ5921@austin.ibm.com> (raw)
In-Reply-To: <1179794459.7189.2.camel@concordia.ozlabs.ibm.com>
On Tue, May 22, 2007 at 10:40:59AM +1000, Michael Ellerman wrote:
> On Mon, 2007-05-21 at 18:18 -0500, Linas Vepstas wrote:
> > Use the correct CONFIG_ option to mark off the EEH bits.
>
> You're making the struct 4 bytes larger by creating a hole here :(
Hmm. Perhaps I could shuffle one of the ints down ...
I figured there might be some vague cache-line benefits to
getting the eeh stuff out of the way.
> > u32 config_space[16]; /* saved PCI config space */
> > +#endif
>
> It looks correct, but I think it's worth mentioning in the changelog
> that config_space was previously unconditionally defined, but is now
> within CONFIG_EEH.
I could just tell that someone would remark on this; why I didn't
mention it, I don't know.
--linas
next prev parent reply other threads:[~2007-05-22 17:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 23:18 [PATCH] pseries: asm/pci-bridge.h CONFIG_ minor cleanup Linas Vepstas
2007-05-22 0:40 ` Michael Ellerman
2007-05-22 17:00 ` Linas Vepstas [this message]
2007-05-22 18:18 ` [PATCH] (revised) " Linas Vepstas
2007-05-23 1:11 ` [PATCH] " Michael Ellerman
2007-05-23 20:51 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070522170058.GJ5921@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).