From: linas@austin.ibm.com (Linas Vepstas)
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 3/4] powerpc: remove dead EEH code.
Date: Thu, 24 May 2007 13:00:40 -0500 [thread overview]
Message-ID: <20070524180039.GL5921@austin.ibm.com> (raw)
In-Reply-To: <20070524095327.75e239b2.sfr@canb.auug.org.au>
On Thu, May 24, 2007 at 09:53:27AM +1000, Stephen Rothwell wrote:
> On Wed, 23 May 2007 12:23:38 -0500 linas@austin.ibm.com (Linas Vepstas) wrote:
> >
> > @@ -1221,11 +1220,10 @@ static int proc_eeh_show(struct seq_file
> > "check not wanted=%ld\n"
> > "eeh_total_mmio_ffs=%ld\n"
> > "eeh_false_positives=%ld\n"
> > - "eeh_ignored_failures=%ld\n"
> > "eeh_slot_resets=%ld\n",
> > no_device, no_dn, no_cfg_addr,
> > ignored_check, total_mmio_ffs,
> > - false_positives, ignored_failures,
> > + false_positives,
> > slot_resets);
>
> This changes a user visible interface - are we sure noone uses it?
> (I suspect it is fine because of the format, but just asking anyway.)
The only user I know of is a "how to test eeh" document that has
a snapshot of this. For the most part, EEH has been very
out-of-the-limelight.
--linas
next prev parent reply other threads:[~2007-05-24 18:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 17:13 [PATCH 0/4] powerpc: EEH blinkenlights, copyright cleanup Linas Vepstas
2007-05-23 17:16 ` [PATCH 1/4] powerpc: Add EEH sysfs blinkenlights Linas Vepstas
2007-05-23 23:22 ` Nathan Lynch
2007-05-24 17:34 ` Linas Vepstas
2007-05-23 23:42 ` Stephen Rothwell
2007-05-23 17:20 ` [PATCH 2/4] powerpc: show EEH per-device false positives Linas Vepstas
2007-05-23 17:23 ` [PATCH 3/4] powerpc: remove dead EEH code Linas Vepstas
2007-05-23 23:53 ` Stephen Rothwell
2007-05-24 18:00 ` Linas Vepstas [this message]
2007-05-23 17:28 ` [PATCH 4/4] powerpc: tweak EEH copyright info Linas Vepstas
2007-05-23 23:55 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070524180039.GL5921@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).