From: Christoph Hellwig <hch@lst.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
ulrich.weigand@de.ibm.com
Subject: Re: [RFC/PATCH 4/5] powerpc: Make syscall restart code more common
Date: Tue, 29 May 2007 13:32:32 +0200 [thread overview]
Message-ID: <20070529113232.GA6071@lst.de> (raw)
In-Reply-To: <20070529064533.CA8C4DDFF8@ozlabs.org>
On Tue, May 29, 2007 at 04:45:23PM +1000, Benjamin Herrenschmidt wrote:
> +static inline void check_syscall_restart(struct pt_regs *regs,
> + struct k_sigaction *ka,
> + int has_handler)
> +{
I don't think this should be inlined. Just create a new signal.c file,
which can grow a lot more common signal code later on aswell.
next prev parent reply other threads:[~2007-05-29 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 6:45 [RFC/PATCH 4/5] powerpc: Make syscall restart code more common Benjamin Herrenschmidt
2007-05-29 11:32 ` Christoph Hellwig [this message]
2007-05-29 11:41 ` Benjamin Herrenschmidt
2007-05-29 13:30 ` Kumar Gala
2007-05-30 0:53 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070529113232.GA6071@lst.de \
--to=hch@lst.de \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=ulrich.weigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).