From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: linuxppc-dev@ozlabs.org, Olaf Hering <olaf@aepfle.de>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] remove geometry support from ps3 storage driver
Date: Wed, 30 May 2007 12:12:05 +0200 [thread overview]
Message-ID: <20070530101205.GC24586@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0705291114340.7698@pademelon.sonytel.be>
On Tue, May 29, 2007 at 11:15:14AM +0200, Geert Uytterhoeven wrote:
> On Mon, 21 May 2007, Christoph Hellwig wrote:
> > On Mon, May 21, 2007 at 02:53:11PM +0200, Olaf Hering wrote:
> > > The old ps3_storage driver did not support DOS geometry, so there is no
> > > point to start adding code for it.
> >
> > That's not quite true. sd applies some heuristics and has a default
> > geometry if there is no ->bios_param method. Then again this whole
> > gemetry thing really only makes sense on x86.
>
> Would it make sense to have a default implementation in block/ioctl.c?
Maybe. Someone would have to look all over block drivers if there is
something common enough to be considered default. Also some drivers
that never ran on x86 never supported it so they'd need a new method
that always returns an error. I'm not sure whether it'll be worth it
in the end.
prev parent reply other threads:[~2007-05-30 10:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 12:53 [PATCH] remove geometry support from ps3 storage driver Olaf Hering
2007-05-21 12:54 ` [PATCH] set module owner in ps3 modules Olaf Hering
2007-05-21 15:52 ` Geoff Levand
2007-05-21 14:36 ` [PATCH] remove geometry support from ps3 storage driver Geert Uytterhoeven
2007-05-21 14:39 ` Christoph Hellwig
2007-05-21 17:14 ` Olaf Hering
2007-05-29 9:15 ` Geert Uytterhoeven
2007-05-30 10:12 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070530101205.GC24586@lst.de \
--to=hch@lst.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).