From: David Gibson <david@gibson.dropbear.id.au>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: Consolidate cuboot initialization code
Date: Thu, 31 May 2007 11:33:37 +1000 [thread overview]
Message-ID: <20070531013337.GC14432@localhost.localdomain> (raw)
In-Reply-To: <465D9672.9060100@freescale.com>
On Wed, May 30, 2007 at 10:21:22AM -0500, Scott Wood wrote:
> David Gibson wrote:
> > On Wed, May 30, 2007 at 10:09:11AM -0500, Scott Wood wrote:
> >>Is there any particular reason to not just do a direct call to
> >>cuboot_init, and move the memcpy and end-of-ram calculation there? I'd
> >>rather avoid macros if possible.
> >
> > Uh.. yeah.. because cuboot_init() doesn't know the size to memcpy(),
> > because it doesn't have the right bd_t definition.
>
> Ah, yes. Don't mind me, it's still morning here... :-P
>
> We could probably do away with the copy altogether, though, as u-boot
> puts the bd_t near the stack, which is exempted from the bootwrapper's
> heap with the 1MiB exclusion.
Possibly, though the copy is safer. I'm hoping to be able to merge
libfdt in a few weeks, which with luck will let me get rid of malloc()
entirely. I'll think about revisiting this then.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
prev parent reply other threads:[~2007-05-31 1:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 2:01 Consolidate cuboot initialization code David Gibson
2007-05-30 15:09 ` Scott Wood
2007-05-30 15:12 ` David Gibson
2007-05-30 15:21 ` Scott Wood
2007-05-31 1:33 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070531013337.GC14432@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).