From: Gabriel Paubert <paubert@iram.es>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 2/8] Add uli1575 pci-bridge sector to MPC8641HPCN dts file.
Date: Sun, 3 Jun 2007 02:13:23 +0200 [thread overview]
Message-ID: <20070603001323.GA25653@iram.es> (raw)
In-Reply-To: <1180828253.14025.22.camel@localhost.localdomain>
On Sun, Jun 03, 2007 at 09:50:53AM +1000, Benjamin Herrenschmidt wrote:
> Minor nits (in addition to needing a "reg" property)
>
> > +
> > + i8259: i8259@4d0 {
>
> Name should probably be "interrupt-controller" as well to follow the
> recommended naming practice.
>
> > + clock-frequency = <0>;
> > + interrupt-controller;
> > + device_type = "interrupt-controller";
> > + #address-cells = <0>;
> > + #interrupt-cells = <2>;
> > + built-in;
> > + compatible = "chrp,iic";
> > + big-endian;
>
> big-endian ? On a 8259 ?
Yes, I spotted that too. Funny on a device which is only ever
accessed through inb/outb!
Maybe the 0x4d0/4d1 ports can be accessed with 16 bit
instructions, I don't know. What I know for sure is that
accessing port 0x20 with an inl/outl on some boards
locks immediately the system up (perhaps through infinite
retries).
Gabriel
next prev parent reply other threads:[~2007-06-03 0:13 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 17:48 [PATCH 2/8] Add uli1575 pci-bridge sector to MPC8641HPCN dts file Jon Loeliger
2007-06-01 18:58 ` Segher Boessenkool
2007-06-01 21:45 ` Wade Farnsworth
2007-06-02 8:22 ` Segher Boessenkool
2007-06-02 8:53 ` Gabriel Paubert
2007-06-02 9:01 ` Segher Boessenkool
2007-06-02 19:53 ` Gabriel Paubert
2007-06-02 20:23 ` Segher Boessenkool
2007-06-03 0:01 ` Benjamin Herrenschmidt
2007-06-03 7:41 ` Segher Boessenkool
2007-06-03 8:33 ` Gabriel Paubert
2007-06-03 8:57 ` Segher Boessenkool
2007-06-03 9:12 ` Benjamin Herrenschmidt
2007-06-03 10:02 ` Segher Boessenkool
2007-06-03 10:10 ` Gabriel Paubert
2007-06-03 11:42 ` Segher Boessenkool
2007-06-03 12:43 ` Gabriel Paubert
2007-06-03 14:42 ` Segher Boessenkool
2007-06-03 18:20 ` Gabriel Paubert
2007-06-03 18:56 ` Segher Boessenkool
2007-06-03 9:07 ` Benjamin Herrenschmidt
2007-06-03 9:59 ` Segher Boessenkool
2007-06-03 14:50 ` Jon Loeliger
2007-06-03 17:27 ` Segher Boessenkool
2007-06-04 20:27 ` Andy Fleming
2007-06-04 22:31 ` Randy Vinson
2007-06-05 19:16 ` Andy Fleming
2007-06-05 20:28 ` Randy Vinson
2007-06-06 7:09 ` Benjamin Herrenschmidt
2007-06-07 16:21 ` Andy Fleming
2007-06-07 16:53 ` Segher Boessenkool
2007-06-07 22:12 ` Benjamin Herrenschmidt
2007-06-08 8:29 ` Segher Boessenkool
2007-06-08 8:32 ` Benjamin Herrenschmidt
2007-06-05 6:05 ` Zang Roy-r61911
2007-06-02 23:52 ` Benjamin Herrenschmidt
2007-06-02 23:51 ` Benjamin Herrenschmidt
2007-06-03 8:59 ` Geert Uytterhoeven
2007-06-04 18:50 ` Jon Loeliger
2007-06-04 19:27 ` Segher Boessenkool
2007-06-01 23:28 ` Benjamin Herrenschmidt
2007-06-01 23:36 ` Jon Loeliger
2007-06-02 0:22 ` Benjamin Herrenschmidt
2007-06-02 8:28 ` Segher Boessenkool
2007-06-02 16:04 ` Jon Loeliger
2007-06-02 20:00 ` Segher Boessenkool
2007-06-02 23:16 ` Benjamin Herrenschmidt
2007-06-03 7:37 ` Segher Boessenkool
2007-06-04 0:16 ` Olof Johansson
2007-06-04 8:18 ` Segher Boessenkool
2007-06-02 8:25 ` Segher Boessenkool
2007-06-02 23:50 ` Benjamin Herrenschmidt
2007-06-03 0:13 ` Gabriel Paubert [this message]
2007-06-03 7:42 ` Segher Boessenkool
2007-06-03 7:53 ` Gabriel Paubert
2007-06-04 18:49 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070603001323.GA25653@iram.es \
--to=paubert@iram.es \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).