From: David Gibson <david@gibson.dropbear.id.au>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@ozlabs.org, horms@verge.net.au,
kexec@lists.infradead.org, miltonm@bga.com
Subject: Re: [PATCH] kexec ppc64: fix misaligned cmdline
Date: Tue, 5 Jun 2007 09:49:17 +1000 [thread overview]
Message-ID: <20070604234917.GB10877@localhost.localdomain> (raw)
In-Reply-To: <25445.1180941825@neuling.org>
On Mon, Jun 04, 2007 at 05:23:45PM +1000, Miichael Neuling wrote:
> If the cmdline changes between boots, we can get misalignment of the
> bootargs entry, which in turn corrupts our device tree blob and hence
> kills our kexec boot.
>
> Specifically, if the cmdline length was >= 8 before and the new cmdline
> length is < 8, we can get corruption.
Hrm. Have you considered using dtc for this conversion, rather than
this somewhat dubious looking fs2dt?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-06-04 23:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 7:23 [PATCH] kexec ppc64: fix misaligned cmdline Michael Neuling
2007-06-04 9:22 ` Milton Miller
2007-06-04 9:42 ` Michael Neuling
2007-06-07 1:19 ` Michael Neuling
2007-06-07 16:19 ` Geoff Levand
2007-06-19 5:06 ` Horms
2007-06-04 23:49 ` David Gibson [this message]
2007-06-04 23:56 ` Michael Neuling
2007-06-05 0:16 ` David Gibson
2007-06-05 0:58 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070604234917.GB10877@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).