From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 5 Jun 2007 10:16:32 +1000 From: David Gibson To: Michael Neuling Subject: Re: [PATCH] kexec ppc64: fix misaligned cmdline Message-ID: <20070605001632.GA26483@localhost.localdomain> References: <25445.1180941825@neuling.org> <20070604234917.GB10877@localhost.localdomain> <2554.1181001397@neuling.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <2554.1181001397@neuling.org> Cc: linuxppc-dev@ozlabs.org, horms@verge.net.au, kexec@lists.infradead.org, miltonm@bga.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jun 05, 2007 at 09:56:37AM +1000, Miichael Neuling wrote: > > > If the cmdline changes between boots, we can get misalignment of the > > > bootargs entry, which in turn corrupts our device tree blob and hence > > > kills our kexec boot. > > > > > > Specifically, if the cmdline length was >= 8 before and the new cmdline > > > length is < 8, we can get corruption. > > > > Hrm. Have you considered using dtc for this conversion, rather than > > this somewhat dubious looking fs2dt? > > Numerous times. > > fs2dt needs to be converted to use the device tree library, but that > will take a lot more work than a 5 minute patch. Well, sure.. but do you need fs2dt at all. dtc has an "fs" input mode.. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson