From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: paulus@samba.org, cbe-oss-dev@ozlabs.org
Subject: Re: [patch 1/3] powerpc: fix pci_setup_phb_io_dynamic for pci_iomap
Date: Tue, 5 Jun 2007 00:27:06 +0200 [thread overview]
Message-ID: <200706050027.06670.arnd@arndb.de> (raw)
In-Reply-To: <1180995548.31677.68.camel@localhost.localdomain>
On Tuesday 05 June 2007, Benjamin Herrenschmidt wrote:
>
> On Mon, 2007-06-04 at 20:14 +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd.bergmann@de.ibm.com>
> > We had a problem on a system with only dynamically allocated
> > PCI buses (using of_pci_phb_driver) in combination with libata.
> > This setup ended up having no "primary" phb, which means
> > that pci_io_base never got initialized and all IO port
> > numbers are 64 bit numbers, which is larger than the
> > PIO_MASK limit.
>
> That's for 2.6.22 ? I wonder if a better fix is to initialize
> pci_io_base statically and clear it in iSeries code... didn't I post a
> patch for that a while ago ?
We talked about this, but I can't find a patch from you that did this.
Either way should be fine, mine may be slightly less invasive, while
statically initializing pci_io_base is what you also do in your
rewrite of that code for 2.6.23.
Arnd <><
next prev parent reply other threads:[~2007-06-04 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 18:14 [patch 0/3] cell bug fixes for 2.6.22 Arnd Bergmann
2007-06-04 18:14 ` [patch 1/3] powerpc: fix pci_setup_phb_io_dynamic for pci_iomap Arnd Bergmann
2007-06-04 22:19 ` Benjamin Herrenschmidt
2007-06-04 22:27 ` Arnd Bergmann [this message]
2007-06-06 7:05 ` Benjamin Herrenschmidt
2007-06-04 18:14 ` [patch 2/3] cbe_cpufreq: limit frequency via cpufreq notifier chain Arnd Bergmann
2007-06-04 18:14 ` [patch 3/3] scc_sio: fix link failure Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706050027.06670.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).