From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [patch 4/6] ps3: Disk Storage Driver
Date: Tue, 19 Jun 2007 19:19:38 +0200 [thread overview]
Message-ID: <20070619171938.GA21935@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0706191450120.4069@pademelon.sonytel.be>
On Tue, Jun 19, 2007 at 02:51:25PM +0200, Geert Uytterhoeven wrote:
> On Tue, 19 Jun 2007, Christoph Hellwig wrote:
> > On Fri, Jun 15, 2007 at 01:39:23PM +0200, Geert Uytterhoeven wrote:
> > > From: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
> > >
> > > Add a Disk Storage Driver for the PS3:
> > > - Implemented as a block device driver with a dynamic major
> > > - Disk names (and partitions) are of the format ps3d%c(%u)
> > > - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor
> > > doesn't support scatter-gather
> >
> > Looks good to me. Only nitpicks are:
> >
> > - ps3disk_priv should probably be an inline function instead of a macro
>
> I used a macro because you can do
>
> ps3disk_pri(dev) = ...;
I'm not exactly a fan of macros used as lvalues, but if you really
want this it can go in.
next prev parent reply other threads:[~2007-06-19 17:19 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-15 11:39 [patch 0/6] PS3 Storage Drivers for 2.6.23, take 2 Geert Uytterhoeven
2007-06-15 11:39 ` [patch 1/6] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver Geert Uytterhoeven
2007-06-15 13:27 ` Benjamin Herrenschmidt
2007-06-15 13:32 ` Geert Uytterhoeven
2007-06-18 16:25 ` [patch 1/6] ps3: Preallocate bootmem memory for the PS3 FLASH Milton Miller
2007-06-19 11:36 ` Geert Uytterhoeven
2007-06-15 11:39 ` [patch 2/6] ps3: Storage Driver Core Geert Uytterhoeven
2007-06-15 11:39 ` [patch 3/6] PS3: Storage device registration routines Geert Uytterhoeven
2007-06-15 11:39 ` [patch 4/6] ps3: Disk Storage Driver Geert Uytterhoeven
2007-06-15 14:35 ` David Woodhouse
2007-06-15 14:41 ` Arnd Bergmann
2007-06-15 14:43 ` Geert Uytterhoeven
2007-06-15 16:15 ` Alan Cox
2007-06-15 18:05 ` Geert Uytterhoeven
2007-06-15 21:19 ` David Miller
2007-06-15 22:40 ` James Bottomley
2007-06-15 23:08 ` David Miller
2007-06-15 23:28 ` James Bottomley
2007-06-15 23:37 ` David Miller
2007-06-19 5:56 ` Christoph Hellwig
2007-06-19 6:07 ` David Miller
2007-06-19 8:15 ` Christoph Hellwig
2007-06-15 23:11 ` Alan Cox
2007-06-16 6:21 ` Geert Uytterhoeven
2007-06-19 5:53 ` Christoph Hellwig
2007-06-19 6:03 ` David Miller
2007-06-19 7:06 ` Geert Uytterhoeven
2007-06-15 21:17 ` David Miller
2007-06-15 21:28 ` Jeff Garzik
2007-06-15 21:37 ` David Miller
2007-06-15 21:50 ` Jeff Garzik
2007-06-15 21:55 ` David Miller
2007-06-19 5:43 ` Christoph Hellwig
2007-06-19 12:51 ` Geert Uytterhoeven
2007-06-19 17:19 ` Christoph Hellwig [this message]
2007-06-15 11:39 ` [patch 5/6] ps3: ROM " Geert Uytterhoeven
2007-06-18 16:30 ` Milton Miller
2007-06-19 5:44 ` Christoph Hellwig
2007-06-19 12:29 ` Geert Uytterhoeven
2007-06-20 12:16 ` Milton Miller
2007-06-19 5:51 ` Christoph Hellwig
2007-06-15 11:39 ` [patch 6/6] ps3: FLASH " Geert Uytterhoeven
2007-06-18 16:30 ` Milton Miller
2007-06-19 12:02 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2007-06-21 14:14 [patch 0/6] PS3 Storage Drivers for 2.6.23, take 3 Geert Uytterhoeven
2007-06-21 14:14 ` [patch 4/6] ps3: Disk Storage Driver Geert Uytterhoeven
2007-07-04 13:22 [patch 0/6] PS3 Storage Drivers for 2.6.23, take 4 Geert Uytterhoeven
2007-07-04 13:22 ` [patch 4/6] ps3: Disk Storage Driver Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070619171938.GA21935@lst.de \
--to=hch@lst.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=James.Bottomley@SteelEye.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).