From: Christoph Hellwig <hch@infradead.org>
To: Olof Johansson <olof@lixom.net>
Cc: Christoph Hellwig <hch@infradead.org>,
linuxppc-dev@ozlabs.org, Russell King <rmk+lkml@arm.linux.org.uk>,
linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pcmcia: CompactFlash driver for PA Semi Electra boards
Date: Mon, 25 Jun 2007 20:39:09 +0100 [thread overview]
Message-ID: <20070625193909.GA26021@infradead.org> (raw)
In-Reply-To: <20070625171221.GA6684@lixom.net>
On Mon, Jun 25, 2007 at 12:12:21PM -0500, Olof Johansson wrote:
> Driver for the CompactFlash slot on the PA Semi Electra eval board. It's
> a simple device sitting on localbus, with interrupts and detect/voltage
> control over GPIO.
>
> The driver is implemented as an of_platform driver, and adds localbus
> as a bus being probed by the of_platform framework.
Looks good to me. The only odd thing is the inconsistant use of
#ifdef CONFIG_PCMCIA in setup.c.
next prev parent reply other threads:[~2007-06-25 19:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 1:03 [PATCH] pcmcia: CompactFlash driver for PA Semi Electra boards Olof Johansson
2007-06-25 5:56 ` Christoph Hellwig
2007-06-25 15:50 ` Olof Johansson
2007-06-25 17:12 ` [PATCH v2] " Olof Johansson
2007-06-25 19:39 ` Christoph Hellwig [this message]
2007-06-25 20:43 ` Olof Johansson
2007-07-05 14:49 ` [PATCH v3] " Olof Johansson
2007-07-20 23:48 ` Andrew Morton
2007-07-21 20:18 ` Olof Johansson
2007-08-31 2:43 ` [PATCH -mm] pcmcia: Updates to electra_cf driver Olof Johansson
2007-06-27 11:20 ` [PATCH v2] pcmcia: CompactFlash driver for PA Semi Electra boards Milton Miller
2007-07-05 14:37 ` Olof Johansson
2007-06-27 11:20 ` [PATCH] " Milton Miller
2007-07-05 14:36 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070625193909.GA26021@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).