From: Christoph Hellwig <hch@lst.de>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linux-arch@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
anil.s.keshavamurthy@intel.com, linuxppc-dev@ozlabs.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/3] Remove JPROBE_ENTRY()
Date: Tue, 26 Jun 2007 07:52:36 +0200 [thread overview]
Message-ID: <20070626055236.GA6841@lst.de> (raw)
In-Reply-To: <98c8ff25191ced991066092ffd4899526097da1e.1182822366.git.michael@ellerman.id.au>
On Tue, Jun 26, 2007 at 11:48:51AM +1000, Michael Ellerman wrote:
> AFAICT now that jprobe.entry is a void *, JPROBE_ENTRY doesn't do
> anything useful - so remove it ..
>
> I've left a do-nothing version so that out-of-tree jprobes code will still
> compile without modifications.
Please kill the definition. We don't want to keep unused crap around
just to let code compile. And I have some plans for even deeper change
in this area, so they'll have to change anyway.
next prev parent reply other threads:[~2007-06-26 5:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 1:48 [PATCH 1/3] Make struct jprobe.entry a void * Michael Ellerman
2007-06-26 1:48 ` [PATCH 3/3] Make jprobes a little safer for users Michael Ellerman
2007-06-26 2:00 ` Andrew Morton
2007-06-26 2:06 ` Michael Ellerman
2007-06-26 5:53 ` Christoph Hellwig
2007-06-26 6:03 ` Michael Ellerman
2007-06-26 6:51 ` Andrew Morton
2007-06-26 6:19 ` Abhishek Sagar
2007-06-26 6:34 ` Michael Ellerman
2007-06-26 7:54 ` Abhishek Sagar
2007-06-26 1:48 ` [PATCH 2/3] Remove JPROBE_ENTRY() Michael Ellerman
2007-06-26 5:52 ` Christoph Hellwig [this message]
2007-06-26 3:51 ` [PATCH 1/3] Make struct jprobe.entry a void * Ananth N Mavinakayanahalli
2007-06-26 3:59 ` Ananth N Mavinakayanahalli
2007-06-26 4:35 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070626055236.GA6841@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).