From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mtagate6.de.ibm.com (mtagate6.de.ibm.com [195.212.29.155]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mtagate6.de.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 7A8DDDDFCE for ; Sat, 30 Jun 2007 00:51:00 +1000 (EST) Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5TEotcv1491422 for ; Fri, 29 Jun 2007 14:50:55 GMT Received: from d12av04.megacenter.de.ibm.com (d12av04.megacenter.de.ibm.com [9.149.165.229]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5TEotKo2175130 for ; Fri, 29 Jun 2007 16:50:55 +0200 Received: from d12av04.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5TEos6v002153 for ; Fri, 29 Jun 2007 16:50:55 +0200 Date: Fri, 29 Jun 2007 16:50:10 +0200 From: Christian Krafft To: "linuxppc-dev@ozlabs.org" Subject: [patch] powerpc: sysfs fix compiler warning Message-ID: <20070629165010.1ec5f082@localhost> Mime-Version: 1.0 Content-Type: multipart/signed; boundary=Sig_ePGwYqnp0eUOEtQ4NcF4VyP; protocol="application/pgp-signature"; micalg=PGP-SHA1 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --Sig_ePGwYqnp0eUOEtQ4NcF4VyP Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable From: Christian Krafft This patch fixes the following compiler warning: arch/powerpc/kernel/sysfs.c:385: warning: ignoring return value of `sysfs_create_group', Signed-off-by: Christian Krafft --- linux-2.6.orig/arch/powerpc/kernel/sysfs.c +++ linux-2.6/arch/powerpc/kernel/sysfs.c @@ -380,16 +380,25 @@ int cpu_add_sysdev_attr_group(struct att { int cpu; struct sys_device *sysdev; + int error =3D 0; =20 mutex_lock(&cpu_mutex); =20 for_each_possible_cpu(cpu) { sysdev =3D get_cpu_sysdev(cpu); - sysfs_create_group(&sysdev->kobj, attrs); + error =3D sysfs_create_group(&sysdev->kobj, attrs); + + if (error) { + for_each_possible_cpu(cpu) { + sysdev =3D get_cpu_sysdev(cpu); + sysfs_remove_group(&sysdev->kobj, attrs); + } + break; + } } =20 mutex_unlock(&cpu_mutex); - return 0; + return error; } EXPORT_SYMBOL_GPL(cpu_add_sysdev_attr_group); =20 --=20 Mit freundlichen Gruessen, kind regards, Christian Krafft IBM Systems & Technology Group, Linux Kernel Development IT Specialist Vorsitzender des Aufsichtsrats: Martin Jetter Geschaeftsfuehrung: Herbert Kircher Sitz der Gesellschaft: Boeblingen Registriergericht: Amtsgericht Stuttgart, HRB 243294 --Sig_ePGwYqnp0eUOEtQ4NcF4VyP Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFGhRxD6rqK4qDx+dcRAiBbAJ9qLwIKLAs0suxh14J3MjkkpBDt3wCghkkM xLXmWnwrI1OTu1ngsrFfvJ8= =S9NA -----END PGP SIGNATURE----- --Sig_ePGwYqnp0eUOEtQ4NcF4VyP--