From: Adrian Bunk <bunk@stusta.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Kumar Gala <galak@freescale.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [RFC: 2.6 patch] ppc: remove APUS support
Date: Mon, 2 Jul 2007 01:08:43 +0200 [thread overview]
Message-ID: <20070701230843.GD10869@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0707020053530.30442@anakin>
On Mon, Jul 02, 2007 at 12:55:36AM +0200, Geert Uytterhoeven wrote:
> On Sun, 1 Jul 2007, Adrian Bunk wrote:
> > Current status of APUS:
> > - arch/powerpc/: a patch to remove it is in powerpc.git
> > - arch/ppc/: marked BROKEN since 2 years
> >
> > This patch therefore removes the remaining parts of APUS support.
>
> > --- linux-2.6.22-rc6-mm1/include/asm-m68k/pgtable.h.old 2007-06-30 01:23:33.000000000 +0200
> > +++ linux-2.6.22-rc6-mm1/include/asm-m68k/pgtable.h 2007-06-30 01:23:43.000000000 +0200
> > @@ -107,8 +107,6 @@ extern void *empty_zero_page;
> > /* 64-bit machines, beware! SRB. */
> > #define SIZEOF_PTR_LOG2 2
> >
> > -#define mm_end_of_chunk(addr, len) 0
> > -
> > extern void kernel_set_cachemode(void *addr, unsigned long size, int cmode);
> >
> > /*
> > --- linux-2.6.22-rc6-mm1/drivers/scsi/a2091.c.old 2007-06-30 01:23:53.000000000 +0200
> > +++ linux-2.6.22-rc6-mm1/drivers/scsi/a2091.c 2007-06-30 01:24:08.000000000 +0200
> > @@ -46,8 +46,7 @@ static int dma_setup(struct scsi_cmnd *c
> > struct Scsi_Host *instance = cmd->device->host;
> >
> > /* don't allow DMA if the physical address is bad */
> > - if (addr & A2091_XFER_MASK ||
> > - (!dir_in && mm_end_of_chunk (addr, cmd->SCp.this_residual)))
> > + if (addr & A2091_XFER_MASK)
> > {
> > HDATA(instance)->dma_bounce_len = (cmd->SCp.this_residual + 511)
> > & ~0x1ff;
> > --- linux-2.6.22-rc6-mm1/drivers/scsi/a3000.c.old 2007-06-30 01:24:17.000000000 +0200
> > +++ linux-2.6.22-rc6-mm1/drivers/scsi/a3000.c 2007-06-30 01:24:26.000000000 +0200
> > @@ -54,8 +54,7 @@ static int dma_setup(struct scsi_cmnd *c
> > * end of a physical memory chunk, then allocate a bounce
> > * buffer
> > */
> > - if (addr & A3000_XFER_MASK ||
> > - (!dir_in && mm_end_of_chunk (addr, cmd->SCp.this_residual)))
> > + if (addr & A3000_XFER_MASK)
> > {
> > HDATA(a3000_host)->dma_bounce_len = (cmd->SCp.this_residual + 511)
> > & ~0x1ff;
> > --- linux-2.6.22-rc6-mm1/drivers/scsi/gvp11.c.old 2007-06-30 01:24:35.000000000 +0200
> > +++ linux-2.6.22-rc6-mm1/drivers/scsi/gvp11.c 2007-06-30 01:24:46.000000000 +0200
> > @@ -54,8 +54,7 @@ static int dma_setup(struct scsi_cmnd *c
> > static int scsi_alloc_out_of_range = 0;
> >
> > /* use bounce buffer if the physical address is bad */
> > - if (addr & HDATA(cmd->device->host)->dma_xfer_mask ||
> > - (!dir_in && mm_end_of_chunk (addr, cmd->SCp.this_residual)))
> > + if (addr & HDATA(cmd->device->host)->dma_xfer_mask)
> > {
> > HDATA(cmd->device->host)->dma_bounce_len = (cmd->SCp.this_residual + 511)
> > & ~0x1ff;
>
> These seem to be completely unrelated to removing APUS support?
For APUS mm_end_of_chunk() was an actual function, otherwise it was
always 0.
> Gr{oetje,eeting}s,
>
> Geert
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-07-01 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070701202206.GO10869@stusta.de>
2007-07-01 22:55 ` [RFC: 2.6 patch] ppc: remove APUS support Geert Uytterhoeven
2007-07-01 23:08 ` Adrian Bunk [this message]
2007-07-01 23:24 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070701230843.GD10869@stusta.de \
--to=bunk@stusta.de \
--cc=david@gibson.dropbear.id.au \
--cc=galak@freescale.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).