From: olof@lixom.net (Olof Johansson)
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Should of_device_is_compatible() use strcmp() rather than strncasecmp()?
Date: Tue, 3 Jul 2007 17:36:12 -0500 [thread overview]
Message-ID: <20070703223612.GA27682@lixom.net> (raw)
In-Reply-To: <468ACA6F.5010107@freescale.com>
On Tue, Jul 03, 2007 at 05:15:11PM -0500, Scott Wood wrote:
> How about a CONFIG_NOT_BROKEN_DEVICE_TREE that disables this and other
> legacy stuff? If unset, warnings will be printed whenever broken things
> are detected. Boards which need proper device tree parsing can select
> the config option.
>
> I'd prefer the other way around (CONFIG_BROKEN_DEVICE_TREE), but it'd
> need to default y at first, and kconfig has no unselect command that I
> can see...
What's the value add in doing this? The code to handle both cases still
has to be in there (just under ifdef now). Is there actually any harm
in doing case-insensitive matching today, where things break because
there are conflicting properties with different cases?
Device trees will never be perfect, and it's idiotic of the kernel to
expect them to be. Even with the dts files, there are several of them
that have errors in them. There will be more in the future as well.
-Olof
next prev parent reply other threads:[~2007-07-03 22:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 21:27 Should of_device_is_compatible() use strcmp() rather than strncasecmp()? Scott Wood
2007-07-03 21:54 ` Segher Boessenkool
2007-07-03 22:15 ` Scott Wood
2007-07-03 22:36 ` Olof Johansson [this message]
2007-07-03 22:33 ` Scott Wood
2007-07-03 22:52 ` Segher Boessenkool
2007-07-03 22:41 ` Segher Boessenkool
2007-07-04 3:28 ` Paul Mackerras
2007-07-04 12:09 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070703223612.GA27682@lixom.net \
--to=olof@lixom.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).