From: olof@lixom.net (Olof Johansson)
To: Sonny Rao <sonny@burdell.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, miltonm@bga.com
Subject: Re: [PATCH] pseries: don't die if unknown/missing interrupt controller property
Date: Thu, 5 Jul 2007 08:37:34 -0500 [thread overview]
Message-ID: <20070705133734.GA9215@lixom.net> (raw)
In-Reply-To: <20070702004937.GA15712@kevlar.boston.burdell.org>
On Sun, Jul 01, 2007 at 08:49:37PM -0400, Sonny Rao wrote:
> The pseries platform does not have a default function for init_IRQ and
> does not install one if it doesn't find or doesn't recognize an
> interrupt controller in the device tree. Currently, the kernel dies
> when it tries to call the NULL init_IRQ() function. Clean that up.
Doesn't it make more sense to make init_IRQ() check that the pointer is
set instead? That'll work for more platforms than just pseries.
-Olof
next prev parent reply other threads:[~2007-07-05 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-02 0:49 [PATCH] pseries: don't die if unknown/missing interrupt controller property Sonny Rao
2007-07-05 2:35 ` Sonny Rao
2007-07-05 13:37 ` Olof Johansson [this message]
2007-07-06 9:16 ` Sonny Rao
2007-07-09 17:31 ` [PATCH] [POWERPC] check for NULL ppc_md.init_IRQ() before calling Sonny Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070705133734.GA9215@lixom.net \
--to=olof@lixom.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=paulus@samba.org \
--cc=sonny@burdell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).