From: Arnd Bergmann <arnd@arndb.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] Handle reg-shift property for of_serial ports
Date: Sat, 7 Jul 2007 14:10:14 +0200 [thread overview]
Message-ID: <200707071410.14998.arnd@arndb.de> (raw)
In-Reply-To: <1183784308.3066.16.camel@shinybook.infradead.org>
On Saturday 07 July 2007, David Woodhouse wrote:
>
> The MV64660 has reg-shift==2 for its otherwise 16550-compatible uarts.
> While the bootwrapper copes with this, of_serial.c doesn't. (The udbg
> code doesn't either, but I'll fix that later).
>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Given the existence of the boards, it looks correct to do this.
However, I wonder if it was correct for the MV64660 to claim
compatibily witn ns16550 if the programming model is not exactly
the same. The official OF serial port bindings don't mention the
reg-shift property, so it maybe would have been better to have
a different value for the "compatible" property, in order not
to confuse existing operating systems that implement the standard.
Also, what about etherboot and yaboot? Do they handle this
correctly?
Arnd <><
next prev parent reply other threads:[~2007-07-07 12:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-07 4:58 [PATCH] Handle reg-shift property for of_serial ports David Woodhouse
2007-07-07 12:10 ` Arnd Bergmann [this message]
2007-07-07 14:59 ` David Woodhouse
2007-07-07 16:51 ` David Woodhouse
2007-07-07 17:07 ` Sergei Shtylyov
2007-07-07 17:52 ` Arnd Bergmann
2007-07-07 22:15 ` Segher Boessenkool
2007-07-07 22:12 ` Segher Boessenkool
2007-07-07 17:55 ` Arnd Bergmann
2007-07-07 22:21 ` Segher Boessenkool
2007-07-07 22:06 ` Segher Boessenkool
2007-07-07 16:57 ` [PATCH 1/2] Add 'sparse16550' to of_serial.c and handle 'reg-shift' property David Woodhouse
2007-07-07 16:57 ` [PATCH 2/2] Add 'sparse16550' support to PowerPC bootwrapper David Woodhouse
2007-07-07 22:23 ` [PATCH] Handle reg-shift property for of_serial ports Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707071410.14998.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dwmw2@infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).