[PATCH][POWERPC] document ipic level/sense info

[PATCH][POWERPC] document ipic level/sense info

[Stuart Yoder]

document level and sense information for the Freescale
IPIC interrupt controller


Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
---
 Documentation/powerpc/booting-without-of.txt |   20 +++++++++++++++++++-
 1 files changed, 19 insertions(+), 1 deletions(-)

diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
index c169299..d26e2bd 100644
--- a/Documentation/powerpc/booting-without-of.txt
+++ b/Documentation/powerpc/booting-without-of.txt
@@ -50,13 +50,14 @@ Table of Contents
       g) Freescale SOC SEC Security Engines
       h) Board Control and Status (BCSR)
       i) Freescale QUICC Engine module (QE)
-      g) Flash chip nodes
+      j) Flash chip nodes
 
   VII - Specifying interrupt information for devices
     1) interrupts property
     2) interrupt-parent property
     3) OpenPIC Interrupt Controllers
     4) ISA Interrupt Controllers
+    5) IPIC Interrupt Controllers
 
   Appendix A - Sample SOC node for MPC8540
 
@@ -1878,6 +1879,23 @@ encodings listed below:
 	2 =  high to low edge sensitive type enabled
 	3 =  low to high edge sensitive type enabled
 
+5) Freescale IPIC Interrupt Controllers
+---------------------------------------
+
+IPIC interrupt controllers are specific to Freescale 83xx
+SOCs.  Two cells are required to encode interrupt information.
+The first cell defines the interrupt number.  The second cell
+defines the sense and level information.
+
+Sense and level information follows the Linux convention
+(specified in include/linux/interrupt.h) and should be encoded
+as follows:
+
+	1 =  low to high edge sensitive type enabled
+	2 =  high to low edge sensitive type enabled
+	4 =  active high level sensitive type enabled
+	8 =  active low level sensitive type enabled
+
 
 Appendix A - Sample SOC node for MPC8540
 ========================================
-- 
1.5.0.3

Re: [PATCH][POWERPC] document ipic level/sense info

[Kim Phillips]

On Mon, 9 Jul 2007 13:20:45 -0500
Stuart Yoder <b08248@freescale.com> wrote:

> +5) Freescale IPIC Interrupt Controllers
> +---------------------------------------
> +
> +IPIC interrupt controllers are specific to Freescale 83xx
> +SOCs.  Two cells are required to encode interrupt information.
> +The first cell defines the interrupt number.  The second cell
> +defines the sense and level information.
> +
> +Sense and level information follows the Linux convention
> +(specified in include/linux/interrupt.h) and should be encoded
> +as follows:
> +
> +	1 =  low to high edge sensitive type enabled

the IPIC doesn't support this sense type.

> +	2 =  high to low edge sensitive type enabled
> +	4 =  active high level sensitive type enabled

nor this.

i.e, sense types 1 and 4 should not be documented in an IPIC context.

Kim

Re: [PATCH][POWERPC] document ipic level/sense info

[Segher Boessenkool]

> +Sense and level information follows the Linux convention
> +(specified in include/linux/interrupt.h) and should be encoded
> +as follows:
> +
> +	1 =  low to high edge sensitive type enabled
> +	2 =  high to low edge sensitive type enabled
> +	4 =  active high level sensitive type enabled
> +	8 =  active low level sensitive type enabled

Please note that using the same bit encoding as some Linux
version does buys you (almost) nothing; a good parser for
this OF node should do range/value checking on this property
anyway, translating the values in the process costs nothing.


Segher