From: Vitaly Bordug <vitb@kernel.crashing.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target
Date: Tue, 10 Jul 2007 14:52:56 +0400 [thread overview]
Message-ID: <20070710145256.6ac64e11@localhost.localdomain> (raw)
In-Reply-To: <468FC376.2040405@ru.mvista.com>
On Sat, 07 Jul 2007 20:46:46 +0400
Sergei Shtylyov wrote:
> > +
> > +#ifdef CONFIG_MPC834x_ITX
>
> Erm, isn't this stuff misplaced? Is this really SoC device? I
> remember seeng this in the arch/ppc/ platform code before (in the
> internal tree)...
The point is to declare methods bsp, as mmio access may effectively vary (having bugs or intentionally) from platform to platform. All-in-one driver approach is nice but might be an issue to handle/maintain.
Thanks for looking at it, other notes make sense.
--
Sincerely, Vitaly
next prev parent reply other threads:[~2007-07-11 10:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-07 9:48 [PATCH 1/2] [ide] mmio ide support Vitaly Bordug
2007-07-07 9:49 ` [PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target Vitaly Bordug
2007-07-07 15:07 ` Olof Johansson
2007-07-07 15:12 ` Arnd Bergmann
2007-07-07 16:46 ` Sergei Shtylyov
2007-07-08 13:31 ` Segher Boessenkool
2007-07-10 10:52 ` Vitaly Bordug [this message]
2007-07-11 19:02 ` Sergei Shtylyov
2007-07-07 12:19 ` [PATCH 1/2] [ide] mmio ide support Arnd Bergmann
2007-07-07 16:51 ` Sergei Shtylyov
2007-07-07 18:07 ` Arnd Bergmann
2007-07-08 13:15 ` Bartlomiej Zolnierkiewicz
2007-07-10 18:49 ` Linas Vepstas
2007-07-07 20:02 ` Alan Cox
2007-07-08 0:54 ` Benjamin Herrenschmidt
2007-07-07 15:01 ` Olof Johansson
2007-07-10 10:53 ` Vitaly Bordug
2007-07-07 18:15 ` Sergei Shtylyov
2007-07-07 20:13 ` Alan Cox
2007-07-10 11:02 ` Vitaly Bordug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070710145256.6ac64e11@localhost.localdomain \
--to=vitb@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).