* [PATCH] ide: Use inline function for eieio
@ 2007-07-10 5:23 Kumar Gala
2007-07-10 13:08 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Kumar Gala @ 2007-07-10 5:23 UTC (permalink / raw)
To: bzolnier; +Cc: linux-ide, linuxppc-dev
Move to using inline function variant of eieio instead of inline assmebly.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
commit ff6ce6329e19cb82ee12447fe16c76c3dae7c1f4
tree ef830cd02624a79d7fa8c33b41f7229ff25a7d77
parent b30083183bf4987c8f7e9a8f753002a7ca5dc084
author Kumar Gala <galak@kernel.crashing.org> Tue, 10 Jul 2007 00:13:54 -0500
committer Kumar Gala <galak@kernel.crashing.org> Tue, 10 Jul 2007 00:13:54 -0500
drivers/ide/pci/scc_pata.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ide/pci/scc_pata.c b/drivers/ide/pci/scc_pata.c
index 55bc0a3..b9fd2ac 100644
--- a/drivers/ide/pci/scc_pata.c
+++ b/drivers/ide/pci/scc_pata.c
@@ -165,9 +165,9 @@ scc_ide_outbsync(ide_drive_t * drive, u8 addr, unsigned long port)
ide_hwif_t *hwif = HWIF(drive);
out_be32((void*)port, addr);
- __asm__ __volatile__("eieio":::"memory");
+ eieio();
in_be32((void*)(hwif->dma_base + 0x01c));
- __asm__ __volatile__("eieio":::"memory");
+ eieio();
}
static void
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ide: Use inline function for eieio
2007-07-10 5:23 [PATCH] ide: Use inline function for eieio Kumar Gala
@ 2007-07-10 13:08 ` Sergei Shtylyov
2007-07-10 21:58 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2007-07-10 13:08 UTC (permalink / raw)
To: Kumar Gala; +Cc: linux-ide, bzolnier, linuxppc-dev
Hello.
Kumar Gala wrote:
> Move to using inline function variant of eieio instead of inline assmebly.
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ide: Use inline function for eieio
2007-07-10 13:08 ` Sergei Shtylyov
@ 2007-07-10 21:58 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-07-10 21:58 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, linuxppc-dev
[ added Kou back to cc: ]
On Tuesday 10 July 2007, Sergei Shtylyov wrote:
> Hello.
>
> Kumar Gala wrote:
> > Move to using inline function variant of eieio instead of inline assmebly.
>
> > Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
applied
Please use host driver name ("scc_pata" in this case) instead of "ide" in
the patch summary if your changes are limited to a single host driver.
This helps later when going through git logs.
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
added
Thanks,
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-10 22:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-10 5:23 [PATCH] ide: Use inline function for eieio Kumar Gala
2007-07-10 13:08 ` Sergei Shtylyov
2007-07-10 21:58 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).