From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, arnd@arndb.de, david@gibson.dropbear.id.au
Subject: Re: [PATCH v2] Consolidate mm_context_t definition in mmu.h
Date: Tue, 10 Jul 2007 21:22:34 -0500 [thread overview]
Message-ID: <20070711022234.GI3925@crusty.rchland.ibm.com> (raw)
In-Reply-To: <18068.4589.614583.210312@cargo.ozlabs.ibm.com>
On Wed, Jul 11, 2007 at 09:10:37AM +1000, Paul Mackerras wrote:
> Josh Boyer writes:
>
> > All of the platforms except PPC64 share a common mm_context_t definition.
> > Defining it in mmu.h avoids duplicating it in the platform specific mmu
> > header files. We further consolidate it by having the PPC32 definition
> > share the mm_context_id_t type for the id member.
>
> Unfortunately the string of ifdefs in your consolidated version makes
> my eyes water. I'm not sure it isn't better the way it is.
Eh, you're the maintainer. No worries.
Though realistically, I only added a single ifdef set in the structure. The
rest are all Ben's ;)
josh
prev parent reply other threads:[~2007-07-11 2:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 17:52 [PATCH v2] Consolidate mm_context_t definition in mmu.h Josh Boyer
2007-07-10 23:10 ` Paul Mackerras
2007-07-11 2:22 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070711022234.GI3925@crusty.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).