From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lobo.ruivo.org (lobo.ruivo.org [66.92.68.119]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "lobo.ruivo.org", Issuer "CA Cert Signing Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 41125DDECB for ; Tue, 17 Jul 2007 11:31:36 +1000 (EST) Date: Mon, 16 Jul 2007 21:30:22 -0400 From: Aristeu Rozanski To: Benjamin Herrenschmidt Subject: Re: [PATCH 1/2] adb: create class devices for each adb device Message-ID: <20070717013022.GB20841@cathedrallabs.org> References: <20070716205319.GC30232@cathedrallabs.org> <1184628153.25235.111.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1184628153.25235.111.camel@localhost.localdomain> Cc: linuxppc-dev@ozlabs.org, Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Benjamin, > I don't think class device is the right approach. Classes are supposed > to be a functional binding, ie, in this case, input devices. ADB is a > bus, and as such, you should create an adb bus type and and adb_device > that is an extension of struct device, not struct class device. ok, I'll work on that. > There's also the question of what to do on ADB resets (such as when > doing a sleep/wakeup cycle). Should we wipe out all devices and > re-created them, thus loosing any settings ? Or should we have some way > to attempt at re-matching existing ones ? or maybe generate disconnect/connect events so udev rules can reconfigure each keyboard? -- Aristeu