linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [patch 00/14] Current 4xx patch series
@ 2007-07-17 18:15 Josh Boyer
  2007-07-17 18:15 ` [patch 01/14] Use resource_size_t for serial port IO addresses Josh Boyer
                   ` (13 more replies)
  0 siblings, 14 replies; 20+ messages in thread
From: Josh Boyer @ 2007-07-17 18:15 UTC (permalink / raw)
  To: linuxppc-dev

For those interested, here's my current 4xx patch series.  There are a few
cleanups as a pre-requisite for 40x support, some minimal Walnut support, and
another round of Bamboo patches.  These are all based off of Paul's current
tree.

Patches 1 through 7 are likely ready to be merged if there are no large
objections.  The Walnut stuff likely needs another round or two.  The Bamboo
patches can likely go in, but there is no rush there.

Ethernet for 4xx in general is still provided by the out-of-tree emac rewrite
that Ben and David have poked at.  If it doesn't get merged soon, I'll take
a look at getting it working again.

As an aside, I'll likely be setting up a git tree for 4xx soon.  Hopefully
that will help with some of the larger-ish patches.

josh
-- 

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [patch 14/14] Bamboo zImage wrapper
@ 2007-07-18 17:21 Milton Miller
  2007-07-18 17:51 ` Josh Boyer
  0 siblings, 1 reply; 20+ messages in thread
From: Milton Miller @ 2007-07-18 17:21 UTC (permalink / raw)
  To: Josh Boyer; +Cc: ppcdev

Sorry for the broken reply but the list is broken.

On Wed Jul 18 04:16:01 EST 2007, Josh Boyer wrote:
> Add a bootwrapper for Bamboo

bamboo is what, an evaluation board? for which processor?

> Signed-off-by: Josh Boyer <jwboyer at linux.vnet.ibm.com>
>
> ---
>  arch/powerpc/boot/44x.h             |    1
>  arch/powerpc/boot/Makefile          |    5 -
>  arch/powerpc/boot/bamboo.c          |  126 
> ++++++++++++++++++++++++++++++++++++
>  arch/powerpc/boot/dcr.h             |   11 +++
>  arch/powerpc/boot/treeboot-bamboo.c |   27 +++++++
>  5 files changed, 168 insertions(+), 2 deletions(-)
>
> --- linux-2.6.orig/arch/powerpc/boot/Makefile
> +++ linux-2.6/arch/powerpc/boot/Makefile
> @@ -143,6 +143,7 @@ image-$(CONFIG_PPC_83xx)            += cuImage.83x
>  image-$(CONFIG_PPC_85xx)               += cuImage.85xx
>  image-$(CONFIG_EBONY)                  += treeImage.ebony 
> cuImage.ebony
>  image-$(CONFIG_WALNUT)                 += treeImage.walnut
> +image-$(CONFIG_BAMBOO)                 += treeImage.bamboo
>  endif

You are only making one target.

> +
> +static void bamboo_fixups(void)
> +{
> +       unsigned long sysclk = 33333333;
> +       ibm440ep_fixup_clocks(sysclk, 11059200);
> +       ibm4xx_fixup_memsize();
> +       ibm4xx_reset_eth((u32 *)0xef600e00, (u32 *)0xef600f00);
> +}

This seems to have board specific information ..

> +
> +void bamboo_init(void)
> +{
> +       platform_ops.fixups = bamboo_fixups;
> +       platform_ops.exit = ibm44x_dbcr_reset;
> +       ft_init(_dtb_start, 0, 32);
> +       serial_console_init();
> +}

and so is this (by transitivity).

> --- /dev/null
> +++ linux-2.6/arch/powerpc/boot/treeboot-bamboo.c
> @@ -0,0 +1,27 @@
... [copyright header]
> +#include "ops.h"
> +#include "stdio.h"
> +#include "44x.h"
> +
> +extern char _end[];
> +
> +BSS_STACK(4096);
> +
> +void platform_init(void)
> +{
> +       unsigned long end_of_ram = 0x8000000;
> +       unsigned long avail_ram = end_of_ram - (unsigned long)_end;
> +
> +       simple_alloc_init(_end, avail_ram, 32, 64);
> +       bamboo_init();
> +}

Is there some reason they should not all be merged into this one 
platform file?

I can understand wanting the dcr fixups as a library, but lets wait to 
do the file splits until there are actually users.  Its also easier to 
see what's going to called when all the platform ops are filled in at 
one spot, not spread over multiple files.

milton

^ permalink raw reply	[flat|nested] 20+ messages in thread
end of thread, other threads:[~2007-07-23  0:47 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-17 18:15 [patch 00/14] Current 4xx patch series Josh Boyer
2007-07-17 18:15 ` [patch 01/14] Use resource_size_t for serial port IO addresses Josh Boyer
2007-07-17 18:15 ` [patch 02/14] Rename 4xx paths to 40x Josh Boyer
2007-07-18  3:26   ` David Gibson
2007-07-17 18:15 ` [patch 03/14] 4xx Kconfig cleanup Josh Boyer
2007-07-17 18:15 ` [patch 04/14] 4xx bootwrapper reworks Josh Boyer
2007-07-17 18:15 ` [patch 05/14] 40x MMU Josh Boyer
2007-07-18  3:38   ` David Gibson
2007-07-17 18:15 ` [patch 06/14] 40x decrementer fixes Josh Boyer
2007-07-17 18:15 ` [patch 07/14] Fix 40x build Josh Boyer
2007-07-17 18:15 ` [patch 08/14] Walnut DTS Josh Boyer
2007-07-17 18:15 ` [patch 09/14] Walnut defconfig Josh Boyer
2007-07-17 18:15 ` [patch 10/14] Walnut board support Josh Boyer
2007-07-17 18:15 ` [patch 11/14] Walnut zImage wrapper Josh Boyer
2007-07-17 18:15 ` [patch 12/14] Bamboo DTS Josh Boyer
2007-07-17 18:16 ` [patch 13/14] Bamboo board support Josh Boyer
2007-07-17 18:16 ` [patch 14/14] Bamboo zImage wrapper Josh Boyer
  -- strict thread matches above, loose matches on Subject: below --
2007-07-18 17:21 Milton Miller
2007-07-18 17:51 ` Josh Boyer
2007-07-18 20:11   ` Josh Boyer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).