From: David Gibson <david@gibson.dropbear.id.au>
To: Milton Miller <miltonm@bga.com>
Cc: linuxppc-dev@ozlabs.org, Jon Loeliger <jdl@jdl.com>
Subject: Re: [PATCH 03/11] dtc: complain about unparsed digits in cell lists
Date: Wed, 18 Jul 2007 12:01:04 +1000 [thread overview]
Message-ID: <20070718020104.GD18251@localhost.localdomain> (raw)
In-Reply-To: <dtc-5-03.miltonm@bga.com>
On Sat, Jul 07, 2007 at 01:18:48AM -0500, Milton Miller wrote:
> Check that strtoul() parsed the complete string.
>
> As with the number overflow case, write a non-fatal error
> message to stdout.
>
> Signed-off-by: Milton Miller <miltonm@bga.com>
> ---
> I saw the FIXME and knew how to fix it.
>
> I think the severity should be higher, but opted for the
> detailed error message compared to the fixed string of
> yyerror() and its immediate termination of parsing.
Yeah, it should really result in a fatal error, but delayed until
after parsing and other error checking is complete. Yet another one
for the Great Error Handling Rewrite. This is an improvement for now.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-07-18 2:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-07 6:18 [PATCH 00/11] dtc: some fixes, and make asm labels for data Milton Miller
2007-07-07 6:18 ` [PATCH 02/11] dtc: move declaration of yyerror Milton Miller
2007-07-19 5:02 ` David Gibson
2007-07-07 6:18 ` [PATCH 01/11] dtc: fix asm for version 17 Milton Miller
2007-07-18 1:56 ` David Gibson
2007-07-07 6:18 ` [PATCH 03/11] dtc: complain about unparsed digits in cell lists Milton Miller
2007-07-18 2:01 ` David Gibson [this message]
2007-07-07 6:18 ` [PATCH 05/11] dtc: clean up grow_data_for() Milton Miller
2007-07-07 6:18 ` [PATCH 04/11] dtc: implement labels on memory reserve slots Milton Miller
2007-07-07 6:18 ` [PATCH 06/11] dtc: allow a label: in any dts context Milton Miller
2007-07-07 6:18 ` [PATCH 07/11] dtc: implement labels on property data Milton Miller
2007-07-07 6:18 ` [PATCH 08/11] dtc: store labels in asscending order Milton Miller
2007-07-07 6:18 ` [PATCH 09/11] dtc: add a testcase with labels Milton Miller
2007-07-07 6:18 ` [PATCH 10/11] dtc: align header comments in asm output Milton Miller
2007-07-07 6:18 ` [PATCH 11/11] dtc: format memory reserve as pairs on two lines Milton Miller
2007-07-07 19:24 ` [PATCH 00/11] dtc: some fixes, and make asm labels for data Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070718020104.GD18251@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).