linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Kim Phillips <kim.phillips@freescale.com>
To: "Grant Likely" <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.com
Subject: Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path
Date: Thu, 19 Jul 2007 16:40:36 -0500	[thread overview]
Message-ID: <20070719164036.f3d4c86d.kim.phillips@freescale.com> (raw)
In-Reply-To: <fa686aa40707191243wb4ce9c1n86002405c5d01bab@mail.gmail.com>

On Thu, 19 Jul 2007 13:43:17 -0600
"Grant Likely" <grant.likely@secretlab.ca> wrote:

> On 7/19/07, Scott Wood <scottwood@freescale.com> wrote:
> > Grant Likely wrote:
> > > From: Grant Likely <grant.likely@secretlab.ca>
> > >
> > > To boot from a cuImage requires the device tree to have a
> > > linux,stdout-path property in the chosen node.  This patch adds it
> > > to the .dts files.
> >
> > This will break many current u-boots, as they blindly add a /chosen node
> > regardless of whether one already exists.
> 
> That really should be fixed then.  In the meantime; I'll resubmit the
> patch to add the chosen node; but with it commented out.
> 

the old FLAT_TREE u-boot fdt fixup code renames any existing chosen
node out of the way, and adds its fixed up version as /chosen.

The LIBFDT implementation replaces any existing /chosen with its fixed
up version.

So it all works out.  Adding chosen/linux,stdout-path properties to the
kernel dtses is fine.

btw, why are these changes being limited to the ITX and GP?

Kim

  parent reply	other threads:[~2007-07-19 21:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-19 18:34 [PATCH 0/4] Series short description grant.likely
2007-07-19 18:37 ` [PATCH 1/4] bootwrapper: In cuImage, print message for ENET devices not found in tree Grant Likely
2007-07-19 18:37 ` [PATCH 2/4] mpc8349: Add linux,network-index to ethernet nodes in device tree Grant Likely
2007-07-19 18:37 ` [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path Grant Likely
2007-07-19 18:59   ` Scott Wood
2007-07-19 19:43     ` Grant Likely
2007-07-19 19:58       ` Jerry Van Baren
2007-07-19 20:00         ` Grant Likely
2007-07-19 21:40       ` Kim Phillips [this message]
2007-07-19 21:44         ` Scott Wood
2007-07-19 22:28           ` Kim Phillips
2007-07-20  2:00           ` Jerry Van Baren
2007-07-20 16:14             ` Scott Wood
2007-07-20 16:46               ` Jerry Van Baren
2007-07-23 13:12             ` Timur Tabi
2007-07-19 22:12         ` Grant Likely
2007-07-19 18:37 ` [PATCH 4/4] mpc8349emitx(gp): update defconfigs for 2.6.23 Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070719164036.f3d4c86d.kim.phillips@freescale.com \
    --to=kim.phillips@freescale.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linuxppc-dev@ozlabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).