Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

[Kim Phillips <kim.phillips@freescale.com>]

On Thu, 19 Jul 2007 16:44:27 -0500
Scott Wood <scottwood@freescale.com> wrote:

> Kim Phillips wrote:
> > the old FLAT_TREE u-boot fdt fixup code renames any existing chosen
> > node out of the way, and adds its fixed up version as /chosen.
> > 
> > The LIBFDT implementation replaces any existing /chosen with its fixed
> > up version.
> 
> Could you point out the code that does this?  I don't see it in either 
> the old code or the new.
> 

libfdt (new): do_fdt() calls fdt_chosen(..., force=1), where, in
fdt_chosen(), the check to not replace the existing node is governed by
the value of force.

[in gvb's fdt branch, where an 'fdt addr' command is no longer required
prior to bootm ing, do_bootm_linux() calls fdt_chosen(...,force=0),
so maybe it should be changed to force=1.]

about the old code, you're right, I don't see it either - I must have
been remembering running something else that did the rename.  Sorry for
the noise.

Kim



Kim