From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out002.atlarge.net (out002.atlarge.net [129.41.63.60]) by ozlabs.org (Postfix) with ESMTP id 2ADFBDDF3F for ; Fri, 20 Jul 2007 18:19:43 +1000 (EST) Date: Fri, 20 Jul 2007 10:19:36 +0200 From: Domen Puncer To: leoli@freescale.com Subject: [PATCH] ucc_geth_mii: fix __exit called from __init Message-ID: <20070720081936.GB4529@moe.telargo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linuxppc-embedded@ozlabs.org List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , void __exit uec_mdio_exit(void) is called from - static int __init ucc_geth_init(void) - static void __exit ucc_geth_exit(void) First one would make error path more than just an error. Signed-off-by: Domen Puncer --- drivers/net/ucc_geth_mii.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: work-powerpc.git/drivers/net/ucc_geth_mii.c =================================================================== --- work-powerpc.git.orig/drivers/net/ucc_geth_mii.c +++ work-powerpc.git/drivers/net/ucc_geth_mii.c @@ -272,7 +272,8 @@ int __init uec_mdio_init(void) return of_register_platform_driver(&uec_mdio_driver); } -void __exit uec_mdio_exit(void) +/* called from __init ucc_geth_init, therefore can not be __exit */ +void uec_mdio_exit(void) { of_unregister_platform_driver(&uec_mdio_driver); }