linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] of_detach_node()'s device node argument cannot be const
       [not found] <79c56e775e50c9532c605f67fbe75f3f6c43b08b.1184910625.git.segher@kernel.crashing.org>
@ 2007-07-20  5:58 ` Segher Boessenkool
  2007-07-20  6:11   ` Stephen Rothwell
  0 siblings, 1 reply; 3+ messages in thread
From: Segher Boessenkool @ 2007-07-20  5:58 UTC (permalink / raw)
  To: linuxppc-dev

...since it modifies it (when it sets the OF_DETACHED flag).

Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
---
 arch/powerpc/kernel/prom.c |    2 +-
 include/asm-powerpc/prom.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
index 37ff99b..67a1bda 100644
--- a/arch/powerpc/kernel/prom.c
+++ b/arch/powerpc/kernel/prom.c
@@ -1433,7 +1433,7 @@ void of_attach_node(struct device_node *np)
  * a reference to the node.  The memory associated with the node
  * is not freed until its refcount goes to zero.
  */
-void of_detach_node(const struct device_node *np)
+void of_detach_node(struct device_node *np)
 {
 	struct device_node *parent;
 
diff --git a/include/asm-powerpc/prom.h b/include/asm-powerpc/prom.h
index 1632baa..1bba741 100644
--- a/include/asm-powerpc/prom.h
+++ b/include/asm-powerpc/prom.h
@@ -160,7 +160,7 @@ extern unsigned long __init of_get_flat_dt_root(void);
 
 /* For updating the device tree at runtime */
 extern void of_attach_node(struct device_node *);
-extern void of_detach_node(const struct device_node *);
+extern void of_detach_node(struct device_node *);
 
 /* Other Prototypes */
 extern void finish_device_tree(void);
-- 
1.5.2.1.144.gabc40-dirty

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] of_detach_node()'s device node argument cannot be const
  2007-07-20  5:58 ` [PATCH] of_detach_node()'s device node argument cannot be const Segher Boessenkool
@ 2007-07-20  6:11   ` Stephen Rothwell
  2007-07-20  7:57     ` Segher Boessenkool
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2007-07-20  6:11 UTC (permalink / raw)
  To: Segher Boessenkool; +Cc: linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

On Fri, 20 Jul 2007 07:58:38 +0200 Segher Boessenkool <segher@kernel.crashing.org> wrote:
>
> ...since it modifies it (when it sets the OF_DETACHED flag).

http://patchwork.ozlabs.org/linuxppc/patch?q=Stephen%20Rothwell&id=12212

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] of_detach_node()'s device node argument cannot be const
  2007-07-20  6:11   ` Stephen Rothwell
@ 2007-07-20  7:57     ` Segher Boessenkool
  0 siblings, 0 replies; 3+ messages in thread
From: Segher Boessenkool @ 2007-07-20  7:57 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linuxppc-dev

>> ...since it modifies it (when it sets the OF_DETACHED flag).
>
> http://patchwork.ozlabs.org/linuxppc/patch?q=Stephen% 
> 20Rothwell&id=12212

Ah okay :-)


Segher

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-07-20  7:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <79c56e775e50c9532c605f67fbe75f3f6c43b08b.1184910625.git.segher@kernel.crashing.org>
2007-07-20  5:58 ` [PATCH] of_detach_node()'s device node argument cannot be const Segher Boessenkool
2007-07-20  6:11   ` Stephen Rothwell
2007-07-20  7:57     ` Segher Boessenkool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).