From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de01egw01.freescale.net (de01egw01.freescale.net [192.88.165.102]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "de01egw01.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id B8551DDE9B for ; Wed, 25 Jul 2007 10:07:32 +1000 (EST) Date: Tue, 24 Jul 2007 18:59:46 -0500 From: Kim Phillips To: Benjamin Herrenschmidt Subject: Re: [PATCH] Re: 2.6.22-git hangs during boot on PowerBook G3 in 0.0 seconds Message-Id: <20070724185946.722f34b5.kim.phillips@freescale.com> In-Reply-To: <1185234923.5439.158.camel@localhost.localdomain> References: <20070721192143.GA12144@nospam.com> <20070721212845.GA30977@nospam.com> <20070723172725.b1c14885.kim.phillips@freescale.com> <1185234923.5439.158.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: linuxppc-dev@ozlabs.org, Rutger Nijlunsing List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 24 Jul 2007 09:55:23 +1000 Benjamin Herrenschmidt wrote: > > > > After hours of fun git bisecting, finally found the commit to revert > > > to make my PowerBook G3 Lombard boot again. This does not result in > > > the complains the reverted commit was revering to. > > > > ..but it does on my MPC8360. > > In which circumstances are you trying to translate an address with no > size cell ? for the enumerated PHYs. As the original commit comment states, I was getting these messages: prom_parse: Bad cell count for /qe@e0100000/mdio@2120/ethernet-phy@00 prom_parse: Bad cell count for /qe@e0100000/mdio@2120/ethernet-phy@01 > I also wonder why it hangs on the powerbook... Rutger, I would expect to > see that complaint warning with the reverted patch, what does it say ? > > My Wallstreet (also based on Grackle) doesn't have the problem. Also can > you send me a tarball of /proc/device-tree ? I don't have any of those machines, but it seems that older kernels running on the Lombard emitted: device-tree: Duplicate name in /cpus/PowerPC,750@0, renamed to "l2-cache#1" messages*. Experimenting with adding two chosen nodes (due to a prior thread on this list**) results in a hung kernel on the 8360 also, so perhaps they're related (and the kernel's tolerance to duplicate entries has changed, which explains where I had seen the chosen node being renamed). but yeah, size-cells should be allowed to be 0 (even address-cells) and it may be the case that the Lombard needs some fixup code. Kim * http://lists.infradead.org/pipermail/linux-pcmcia/2007-April/004503.html ** http://ozlabs.org/pipermail/linuxppc-dev/2007-July/039758.html