From: David Brownell <david-b@pacbell.net>
To: spi-devel-general@lists.sourceforge.net
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [spi-devel-general] [PATCH 1/3] [SPI] Sync spidev.{h, c} with spi.h
Date: Thu, 26 Jul 2007 20:02:02 -0700 [thread overview]
Message-ID: <200707262002.02677.david-b@pacbell.net> (raw)
In-Reply-To: <20070726135041.GA5550@localhost.localdomain>
On Thursday 26 July 2007, Anton Vorontsov wrote:
> --- a/drivers/spi/spidev.c
> +++ b/drivers/spi/spidev.c
> @@ -56,8 +56,8 @@ static unsigned long minors[N_SPI_MINORS / BITS_PER_LONG];
>
>
> /* Bit masks for spi_device.mode management */
> -#define SPI_MODE_MASK (SPI_CPHA | SPI_CPOL)
> -
> +#define SPI_MODE_MASK (SPI_CPHA | SPI_CPOL | SPI_CS_HIGH | \
> + SPI_LSB_FIRST | SPI_3WIRE)
Hmm, I seem to recall explicitly leaving out CS_HIGH on the grounds
that getting it wrong could corrupt the whole bus; Not Good (tm).
And the same argument can apply to 3WIRE mode ...
On the other hand, that's not necessarily a good reason, since there
are other ways to trash hardware too.
Comments anyone?
- Dave
next prev parent reply other threads:[~2007-07-27 3:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 13:47 [PATCH 0/3] [SPI] loopback mode support, [POWERPC] loopback mode for spi_mpc83xx Anton Vorontsov
2007-07-26 13:50 ` [PATCH 1/3] [SPI] Sync spidev.{h,c} with spi.h Anton Vorontsov
2007-07-27 3:02 ` David Brownell [this message]
2007-07-26 13:50 ` [PATCH 2/3] [SPI] Add new mode: SPI_LOOP Anton Vorontsov
2007-07-27 3:07 ` [spi-devel-general] " David Brownell
2007-07-27 3:34 ` Ned Forrester
2007-08-01 18:25 ` David Brownell
2007-07-27 13:27 ` Anton Vorontsov
2007-07-26 13:51 ` [PATCH 3/3] [POWERPC][SPI] spi_mpc83xx: add support for loopback mode Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707262002.02677.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).