From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: spi-devel-general@lists.sourceforge.net, linuxppc-dev@ozlabs.org
Subject: Re: [spi-devel-general] [PATCH 1/4] [POWERPC][SPI] spi_mpc83xx.c: should turn off SPI unit while switching any mode.
Date: Fri, 27 Jul 2007 17:36:28 +0400 [thread overview]
Message-ID: <20070727133628.GA19151@localhost.localdomain> (raw)
In-Reply-To: <250FD11F-9ADC-46CC-B652-1148FC549316@kernel.crashing.org>
On Fri, Jul 27, 2007 at 01:32:27AM -0500, Kumar Gala wrote:
>
> On Jul 26, 2007, at 8:13 AM, Anton Vorontsov wrote:
>
>> Documentation clearly states, that mode should not be changed
>> till SPMODE_ENABLE bit set. I've seen hangs w/o this patch.
>
> Out of interest what board/part do you see the hang on?
It's MPC8323E-RDB.
Using spidev_test utility:
root@10.0.0.99:~# ./a.out -D /dev/spidev1.0
spi mode: 0
bits per word: 8
max speed: Hz (kHz): 500000 (500)
...
root@10.0.0.99:~#
Then trying change bits per word to 32:
root@10.0.0.99:~# ./a.out -D /dev/spidev1.0 -b 32
spi mode: 0
bits per word: 32
max speed: Hz (kHz): 500000 (500)
<---- hang
Board is still alive, but SPI isn't.
Though, there are various steps to reproduce the same.
So SPI unit should be really turned off to change mode.
Thanks,
--
Anton Vorontsov
email: cbou@mail.ru
backup email: ya-cbou@yandex.ru
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2007-07-27 13:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 13:11 [PATCH 0/4] Few spi_mpc83xx.c fixes and improvements Anton Vorontsov
2007-07-26 13:13 ` [PATCH 1/4] [POWERPC][SPI] spi_mpc83xx.c: should turn off SPI unit while switching any mode Anton Vorontsov
2007-07-27 6:32 ` [spi-devel-general] " Kumar Gala
2007-07-27 13:36 ` Anton Vorontsov [this message]
2007-07-26 13:14 ` [PATCH 2/4] [POWERPC][SPI] spi_mpc83xx: get rid of magic numbers Anton Vorontsov
2007-07-26 13:14 ` [PATCH 3/4] [POWERPC][SPI] spi_mpc83xx: support for lsb mode switching Anton Vorontsov
2007-07-26 13:14 ` [PATCH 4/4] [POWERPC][SPI] spi_mpc83xx: fix LSB mode shifts Anton Vorontsov
2007-07-27 2:58 ` [spi-devel-general] [PATCH 0/4] Few spi_mpc83xx.c fixes and improvements David Brownell
2007-07-27 6:32 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070727133628.GA19151@localhost.localdomain \
--to=avorontsov@ru.mvista.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).