From: linas@austin.ibm.com (Linas Vepstas)
To: Jan-Bernd Themann <ossthema@de.ibm.com>
Cc: Thomas Klein <tklein@de.ibm.com>, Jeff Garzik <jeff@garzik.org>,
Jan-Bernd Themann <themann@de.ibm.com>,
netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Christoph Raisch <raisch@de.ibm.com>,
Marcus Eder <meder@de.ibm.com>,
Andrew Gallatin <gallatin@myri.com>,
Stefan Roscher <stefan.roscher@de.ibm.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic
Date: Mon, 30 Jul 2007 12:00:40 -0500 [thread overview]
Message-ID: <20070730170038.GA4884@austin.ibm.com> (raw)
In-Reply-To: <200707301724.33865.ossthema@de.ibm.com>
On Mon, Jul 30, 2007 at 05:24:33PM +0200, Jan-Bernd Themann wrote:
>
> Changes to http://www.spinics.net/lists/netdev/msg36912.html
>
> 1) A new field called "features" has been added to the net_lro_mgr struct.
> It is set by the driver to indicate:
> - LRO_F_NAPI: Use NAPI / netif_rx to pass packets to stack
>
> - LRO_F_EXTRACT_VLAN_ID: Set by driver if HW extracts VLAN IDs for VLAN
> packets but does not modify ETH protocol (ETH_P_8021Q)
>
> 2) Padded frames are not aggregated for now. Bug fixed
>
> 3) Correct header length now used. No minimal header length for aggregated
> packets used anymore.
>
> 4) Statistic counters were introduced. They are stored in a new struct in
> the net_lro_mgr. This has the advantage that no locking is required in
> cases where the driver uses multiple lro_mgrs for different receive queues.
> Thus we get the following statistics per lro_mgr / eth device:
> - Number of aggregated packets
> - Number of flushed packets
> - Number of times we run out of lro_desc.
>
> The ratio of "aggregated packets" and "flushed packets" give you an
> idea how well LRO is working.
I'd like to see an edited form of this, together with an introduction to
LRO, written up in the Documentation subdirectory.
As someone with some driver experience, but not on te bleeding edge,
some basc newbie questions pop into mind:
-- what is LRO?
-- Basic principles of operation?
-- Can I use it in my driver?
-- Does my hardware have to have some special feature before I can use it?
-- What sort of performance improvement does it provide? Throughput?
Latency? CPU usage? How does it affect DMA allocation? Does it
improve only a certain type of traffic (large/small packets, etc.)
-- Example code? What's the API? How should my driver use it?
Right now, I can maybe find answers by doing lots of googling. I'd like
to have some quick way of getting a grip on this.
--linas
next prev parent reply other threads:[~2007-07-30 17:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 15:24 [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic Jan-Bernd Themann
2007-07-30 16:17 ` Jeff Garzik
2007-07-30 22:43 ` David Miller
2007-07-31 0:00 ` Jeff Garzik
2007-07-30 17:00 ` Linas Vepstas [this message]
2007-07-30 17:43 ` Andrew Gallatin
2007-07-30 19:57 ` Stephen Hemminger
2007-07-31 3:58 ` Leonid Grossman
2007-07-30 20:32 ` Andrew Gallatin
2007-07-31 10:33 ` Jan-Bernd Themann
2007-07-31 13:34 ` Andrew Gallatin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070730170038.GA4884@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=davem@davemloft.net \
--cc=gallatin@myri.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=stefan.roscher@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).