From: David Brownell <david-b@pacbell.net>
To: spi-devel-general@lists.sourceforge.net
Cc: Ned Forrester <nforrester@whoi.edu>,
linuxppc-dev@ozlabs.org,
Stephen Street <stephen@streetfiresound.com>
Subject: Re: [spi-devel-general] [PATCH 2/3] [SPI] Add new mode: SPI_LOOP
Date: Wed, 1 Aug 2007 11:25:47 -0700 [thread overview]
Message-ID: <200708011125.47934.david-b@pacbell.net> (raw)
In-Reply-To: <46A967D5.30606@whoi.edu>
On Thursday 26 July 2007, Ned Forrester wrote:
> David Brownell wrote:
> > On Thursday 26 July 2007, Anton Vorontsov wrote:
> >> Loopback mode is supported by various controllers, this mode
> >> is useful for testing, especially in conjunction with spidev
> >> driver.
> >
> > ISTR that Stephen Street provided a loopback mode for debug
> > in his pxa2xx_spi code. And I know you're fight that this
> > mode shows up in a lot of hardware.
> >
> > Comments, anyone? This seems like a fair way to expose this
> > mechanism. And I tend to agree that it'd mostly be useful in
> > conjunction with "spidev".
>
> Yes, it is in pxa2xx_spi. It is passed in a structure that is attached
> to spi_board_info.controller_data. I have used it to great effect to
> test data modes in the driver for which I have no external hardware
> support: various bits/word, clock frequencies, fifo thresholds, dma
> burst sizes, etc.
Well, the SPI_LOOP stuff is now in kernel.org GIT and 2.6.23-rc2,
so if someone wants to update pxa2xx_spi to support this through
spi->mode instead of controller data, now is a good time to start
working on that.
- Dave
next prev parent reply other threads:[~2007-08-01 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 13:47 [PATCH 0/3] [SPI] loopback mode support, [POWERPC] loopback mode for spi_mpc83xx Anton Vorontsov
2007-07-26 13:50 ` [PATCH 1/3] [SPI] Sync spidev.{h,c} with spi.h Anton Vorontsov
2007-07-27 3:02 ` [spi-devel-general] [PATCH 1/3] [SPI] Sync spidev.{h, c} " David Brownell
2007-07-26 13:50 ` [PATCH 2/3] [SPI] Add new mode: SPI_LOOP Anton Vorontsov
2007-07-27 3:07 ` [spi-devel-general] " David Brownell
2007-07-27 3:34 ` Ned Forrester
2007-08-01 18:25 ` David Brownell [this message]
2007-07-27 13:27 ` Anton Vorontsov
2007-07-26 13:51 ` [PATCH 3/3] [POWERPC][SPI] spi_mpc83xx: add support for loopback mode Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708011125.47934.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=nforrester@whoi.edu \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=stephen@streetfiresound.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).