From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Roland Dreier <rdreier@cisco.com>,
linux-kernel@vger.kernel.org, raisch@de.ibm.com,
paulus@samba.org, general@lists.openfabrics.org,
Hoang-Nam Nguyen <hnguyen@linux.vnet.ibm.com>
Subject: Re: [PATCH] ehca: map 4k firmware context of cq, qp to user space
Date: Thu, 2 Aug 2007 16:08:15 +0200 [thread overview]
Message-ID: <200708021608.16436.arnd@arndb.de> (raw)
In-Reply-To: <200708021139.31695.hnguyen@linux.vnet.ibm.com>
On Thursday 02 August 2007, Hoang-Nam Nguyen wrote:
> +#ifdef CONFIG_PPC_64K_PAGES
> +=A0=A0=A0=A0=A0=A0=A0/* make sure we map only 4k for fw context */
> +=A0=A0=A0=A0=A0=A0=A0ret =3D remap_4k_pfn(vma, vma->vm_start, physical >=
> EHCA_PAGESHIFT,
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =
=A0 vma->vm_page_prot);
> +#else
> =A0=A0=A0=A0=A0=A0=A0=A0ret =3D remap_pfn_range(vma, vma->vm_start, physi=
cal >> PAGE_SHIFT,
> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =
=A0 =A0 =A0vsize, vma->vm_page_prot);
> +#endif
remap_4k_pfn is defined in terms of remap_pfn_range if the base page
size if 4k, so you don't need this #ifdef afaics.
otherwise, the patch looks good.
Arnd <><
next prev parent reply other threads:[~2007-08-02 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-02 9:39 [PATCH] ehca: map 4k firmware context of cq, qp to user space Hoang-Nam Nguyen
2007-08-02 14:08 ` Arnd Bergmann [this message]
2007-08-02 21:03 ` Roland Dreier
2007-08-03 8:36 ` Hoang-Nam Nguyen
2007-08-08 14:13 ` Hoang-Nam Nguyen
2007-08-08 16:08 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708021608.16436.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=general@lists.openfabrics.org \
--cc=hnguyen@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=raisch@de.ibm.com \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).