From: David Brownell <david-b@pacbell.net>
To: Christoph Hellwig <hch@lst.de>
Cc: linuxppc-dev@ozlabs.org, Domen Puncer <domen.puncer@telargo.com>,
Russell King <rmk@arm.linux.org.uk>,
linux-mips@linux-mips.org
Subject: Re: Generic clk.h wrappers? [Was: Re: [PATCH 1/3] powerpc clk.h interface for platforms]
Date: Thu, 2 Aug 2007 16:32:13 -0700 [thread overview]
Message-ID: <200708021632.13982.david-b@pacbell.net> (raw)
In-Reply-To: <20070801125753.GB27199@lst.de>
On Wednesday 01 August 2007, Christoph Hellwig wrote:
> On Wed, Aug 01, 2007 at 09:28:07AM +0200, Domen Puncer wrote:
> > > It doesn't make any assumption on struct clk, it's just a
> > > wrapper around functions from clk.h.
> > > Point of this patch was to abstract exported functions, since
> > > arch/powerpc/ can support multiple platfroms in one binary.
> >
> > So... the thread just ended without any consensus, ACK or whatever.
> >
> > Choices I see:
> > - have EXPORT_SYMBOL for clk.h functions in ie. lib/clock.c and have
> > every implemenation fill some global struct.
> > - leave this patch as it is, abstraction only for arch/powerpc/.
That seems the best solution for now, I agree.
> > - or I can just forget about this, and leave it for the next sucker
> > who will want nicer clock handling in some driver
>
> It seems like arm really wants this optimized to the last cycle
> and no abstraction inbetween so we're probably stuck with the status
> quo. I'm pretty sure this will get too messy sooner and later and
> people will clean the mess up, but due to the political issues I
> don't think it's fair to put that burden on you just for submitting
> the powerpc implementation.
>
> So, please leave the patch as-is.
>
next prev parent reply other threads:[~2007-08-02 23:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 9:31 [PATCH 0/3] clock (clk.h) framework for mpc52xx Domen Puncer
2007-07-11 9:32 ` [PATCH 1/3] powerpc clk.h interface for platforms Domen Puncer
2007-07-11 10:36 ` Christoph Hellwig
2007-07-11 15:56 ` David Brownell
2007-07-11 16:16 ` Christoph Hellwig
2007-07-11 17:02 ` David Brownell
2007-07-11 20:34 ` Russell King
2007-07-11 20:52 ` David Brownell
2007-07-13 9:12 ` Domen Puncer
2007-08-01 7:28 ` Generic clk.h wrappers? [Was: Re: [PATCH 1/3] powerpc clk.h interface for platforms] Domen Puncer
2007-08-01 12:57 ` Christoph Hellwig
2007-08-02 23:32 ` David Brownell [this message]
2007-08-03 8:36 ` Russell King
2007-08-06 6:58 ` [PATCH 1/3] powerpc clk.h interface for platforms Domen Puncer
2007-09-19 3:47 ` Paul Mackerras
2007-09-19 5:11 ` Domen Puncer
2007-09-20 5:07 ` Paul Mackerras
2007-09-20 14:00 ` [PATCH 1/3 v2] " Domen Puncer
2007-07-11 9:33 ` [PATCH 2/3] mpc52xx clk.h interface Domen Puncer
2007-07-11 9:34 ` [PATCH 3/3] mpc52xx_psc_spi: use clk.h subsystem Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708021632.13982.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=domen.puncer@telargo.com \
--cc=hch@lst.de \
--cc=linux-mips@linux-mips.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).